[1.0.x] Taxonomy Term Replace

Thank you for applying!

Please read Review process for security advisory coverage: What to expect for more details and Security advisory coverage application checklist to understand what reviewers look for. Tips for ensuring a smooth review gives some hints for a smoother review.

The important notes are the following.

• If you have not done it yet, you should run phpcs --standard=Drupal,DrupalPractice on the project, which alone fixes most of what reviewers would report.
• For the time this application is open, only your commits are allowed.
• The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
• We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.

To the reviewers

Please read How to review security advisory coverage applications, Application workflow, What to cover in an application review, and Tools to use for reviews.

The important notes are the following.

• It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
• Reviewers should show the output of a CLI tool only once per application.
• It may be best to have the applicant fix things before further review.

For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues.

I am changing priority as per Issue priorities.

• The following points are just a start and don't necessarily encompass all of the changes that may be necessary
• A specific point may just be an example and may apply in other places
• A review is about code that doesn't follow the coding standards, contains possible security issue, or doesn't correctly use the Drupal API; the single points aren't ordered, not even by importance

src/Form/TaxonomyTermConfirmationForm.php & TaxonomyTermReplaceForm.php

    $target_term_id = base64_decode($request->query->get('target_term_id'));
    $replacement_term_id = base64_decode($request->query->get('replacement_term_id'));
    $total_nodes = base64_decode($request->query->get('total_nodes'));
    $target_term = base64_decode($request->query->get('target_term'));
    $replacement_term = base64_decode($request->query->get('replacement_term'));

sanitize user inputted text

I am changing priority as per Issue priorities.

Given the used code is the following one, the user input is correctly sanitized, and at the right moment.

    $target_term_id = base64_decode($request->query->get('target_term_id'));
    $replacement_term_id = base64_decode($request->query->get('replacement_term_id'));
    $total_nodes = base64_decode($request->query->get('total_nodes'));
    $target_term = base64_decode($request->query->get('target_term'));
    $replacement_term = base64_decode($request->query->get('replacement_term'));
    $form['confirmation'] = [
      '#markup' => $this->t('You will be replacing term @target_term (Term ID  - @target_term_id) with @replacement_term (Term ID - @replacement_term_id) for a total of @total_nodes nodes associated to @target_term.', [
        '@target_term_id' => $target_term_id,
        '@replacement_term_id' => $replacement_term_id,
        '@total_nodes' => $total_nodes,
        '@target_term' => $target_term,
        '@replacement_term' => $replacement_term,
      ]),
    ];

Thank you for your contribution and for your patience with the review process!

I am going to update your account so you can opt into security advisory coverage any project you create, including the projects you already created.

These are some recommended readings to help you with maintainership:

• Dries' post on Responsible maintainers
• Maintainership
• Git version control system
• Issue procedures and etiquette
• Maintaining and responding to issues for a project
• Release naming conventions.

You can find more contributors chatting on Slack or IRC in #drupal-contribute. So, come hang out and stay involved!
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank the dedicated reviewers as well.

To enable the green security coverage indicator, go to the module's project page and click "Edit." Find the "Security advisory coverage" section, check the box for "Opt into security advisory coverage," and save the changes. After doing this, the green security badge will be displayed on the project page.