Problem/Motivation

While working on #3472334: Project browser filters are conflicting after switching between different tabs it was found that selected categories disappear when tabs are changed. This issue is probable introduced in #3318817: Improve the categories filter type in context to the rest of the filter component ui .

Steps to reproduce

  • Enable Drupal core plugin
  • On Drupal.org(JSON:API), click clear filters
  • Select first 3 categories from category dropdown
  • Switch tab to Drupal core plugin and select one category, eg: Core(Experimental)
  • Switch tabs in random order to see the issue

Proposed resolution

Issue fork project_browser-3481084

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

narendrar created an issue. See original summary.

narendrar opened merge request !603

narendrar’s picture

narendrar
He/Him
Primary language English
Location Jaipur, India
commented
Status: Active » Needs review
rkoller’s picture

rkoller
he/him
Primary language German
Location Nürnberg, Germany
commented

oh i havent realized that those empty selected filters with the undefined chips could happen on and off! i always ran right away into it as soon as i've switched to the core modules source type. never tried switching tabs repeatedly, so never fully grasped that the hiding can switch on and off. at first i thought this issue wouldnt be reproducible and about something else than i've raised in the slack on thread. but understood now the steps to reproduce and also am able to confirm that the MR603 fixes the issue. thank you! only tested the MR functionally/manually, leave it at needs review that someone else can also review the code.

utkarsh_33’s picture

utkarsh_33 commented
Status: Needs review » Reviewed & tested by the community

I tested the MR and the issue reported here is fixed, also the code changes looks good to me so marking it RTBC.

chrisfromredfin made their first commit to this issue’s fork.

chrisfromredfin’s picture

chrisfromredfin
he/him/his
Primary language English
Location Portland, Maine
commented
Status: Reviewed & tested by the community » Fixed

Woohoo! Testing this caused me to notice separate issues with the Core plugin but they are present on 2.0.x without this MR. And this MR seems to fix the issue the way I caused it. And RTBC with two other manual tests, so here it goes!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.