Problem/Motivation

So when a user has 2 browse(Project browser) tabs open and if a user changes the value of number of modules that the user wants to see from say 12 items per page to 24 items per page and then visit the second tab and refresh the tab, then ideally it should also have the change in the value of pagination reflected ie now no of items per page should be set to 24 for both the tabs.

Steps to reproduce

Open 2 browse windows and then set the value of items per page to any thing other than the default value and then navigate to the other browser tab and refresh.
You would notice different values in Items per page across the 2 tabs.

Proposed resolution

Issue fork project_browser-3480064

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

utkarsh_33 created an issue. See original summary.

utkarsh_33 opened merge request !599

utkarsh_33’s picture

utkarsh_33 commented
Title: Make pagination more consistent. » Make pagination more consistent between tabs.
utkarsh_33’s picture

utkarsh_33 commented
Assigned: utkarsh_33 » Unassigned
Status: Active » Needs review

Not sure whether this needs test or not.

chrisfromredfin’s picture

chrisfromredfin
he/him/his
Primary language English
Location Portland, Maine
commented
Status: Needs review » Needs work
Issue tags: +Needs tests

I think it does because I think if we revert the change accidentally elsewhere we'd want to know.

chrisfromredfin’s picture

chrisfromredfin
he/him/his
Primary language English
Location Portland, Maine
commented
Issue tags: +core-mvp, +beta blocker
narendrar’s picture

narendrar
He/Him
Primary language English
Location Jaipur, India
commented

Discussed with @fjgarlin over slack at https://drupal.slack.com/archives/C01UHB4QG12/p1732554159976349?thread_ts=1732533199.035789&cid=C01UHB4QG12 that this issue requires a new endpoint in DrupalOrgClientMiddleware. But filter ID's are changed on DO, so an update in fixture is required before working on this issue further. Next steps once fixture is regenerated:

  • Add testPagingOptions test in ProjectBrowserUiTestJsonApi.php also, which currently exists in ProjectBrowserUiTest.php
  • Add new endpoint in DrupalOrgClientMiddleware.php and use in above test
  • Fix nightwatch test.
fjgarlin’s picture

fjgarlin commented
Related issues: +#3489810: Improve fixture regeneration script

I'm doing the fixes for the regeneration script at #3489810: Improve fixture regeneration script

utkarsh_33’s picture

utkarsh_33 commented
Status: Needs work » Needs review

This is ready for reviews now.The CI fails are unrelated.

chrisfromredfin’s picture

chrisfromredfin
he/him/his
Primary language English
Location Portland, Maine
commented
Status: Needs review » Needs work

I have one small nit (filename) and then this needs manual testing but then is probably ready to go.

utkarsh_33’s picture

utkarsh_33 commented
Status: Needs work » Needs review

Ready for review and manual testing.

narendrar’s picture

narendrar
He/Him
Primary language English
Location Jaipur, India
commented
Status: Needs review » Reviewed & tested by the community

Tested manually, and the change in page size in one tab is properly reflected in another tab. Moving it to RTBC.

chrisfromredfin’s picture

chrisfromredfin
he/him/his
Primary language English
Location Portland, Maine
commented
Status: Reviewed & tested by the community » Fixed

teamwork makes the dream work.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.