This module uses the Media Thumbnails framework to create media entity thumbnails for SVG files. It's basically a plugin that rasterizes an SVG file and returns the bitmap image (PNG) as a managed file entity for Media Thumbnails.

https://www.drupal.org/project/media_thumbnails_svg

Comments

drubb created an issue. See original summary.

vishal.kadam’s picture

Thank you for applying!

Please read Review process for security advisory coverage: What to expect for more details and Security advisory coverage application checklist to understand what reviewers look for. Tips for ensuring a smooth review gives some hints for a smoother review.

The important notes are the following.

  • If you have not done it yet, you should run phpcs --standard=Drupal,DrupalPractice on the project, which alone fixes most of what reviewers would report.
  • For the time this application is open, only your commits are allowed.
  • The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
  • We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.

To the reviewers

Please read How to review security advisory coverage applications, Application workflow, What to cover in an application review, and Tools to use for reviews.

The important notes are the following.

  • It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
  • Reviewers should show the output of a CLI tool only once per application.
  • It may be best to have the applicant fix things before further review.

For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues.

avpaderno’s picture

Status: Needs review » Needs work

Usually, after reviewing a project, we allow the developer to opt projects into security advisory coverage. This project is too small for us and it doesn't contain enough PHP code to really assess your skills as developer.

Have you created any other project on drupal.org (module, theme, distribution) we could instead review? The project needs to have most of the commits (preferable all the commits) done by you.

drubb’s picture

Status: Needs work » Needs review

Thanks for taking a look. Yes, there are related projects where most commits are by me:

https://www.drupal.org/project/media_thumbnails
https://www.drupal.org/project/media_thumbnails_pdf
https://www.drupal.org/project/media_thumbnails_svg

The first two have been opted in by a new co-maintainer recently.

rushikesh raval’s picture

Status: Needs review » Needs work

Update this application summary for project you want to review for which most of commit done by you.

drubb’s picture

Title: [2.0.x] Media Thumbnails EPUB » [2.0.x] Media Thumbnails SVG
Issue summary: View changes
Status: Needs work » Needs review

Ok, I've now switched the application to Media Thumbnails SVG:

https://www.drupal.org/project/media_thumbnails_svg

It has a bit more PHP code, but not much more, due to its nature as plugin.

The project with the most code written by me would be https://www.drupal.org/project/media_thumbnails,
but this project already has been opted in for security coverage.

drubb’s picture

Title: [2.0.x] Media Thumbnails SVG » [2.x] Media Thumbnails SVG
rushikesh raval’s picture

Priority: Normal » Major

I am changing priority as per Issue priorities.

klausi’s picture

Status: Needs review » Fixed
Issue tags: +ContributionWeekend2025

Boris!!!!! Why are you not approved yet after all those years?

manual review:
The escapeshellarg() calls all look correct to me.

Thanks for your contribution, Boris!

I updated your account so you can opt into security advisory coverage now.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on Slack or IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.