Closed (fixed)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Major
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
3 Oct 2024 at 15:15 UTC
Updated:
8 Feb 2025 at 18:39 UTC
Jump to comment: Most recent
Comments
Comment #2
vishal.kadamThank you for applying!
Please read Review process for security advisory coverage: What to expect for more details and Security advisory coverage application checklist to understand what reviewers look for. Tips for ensuring a smooth review gives some hints for a smoother review.
The important notes are the following.
phpcs --standard=Drupal,DrupalPracticeon the project, which alone fixes most of what reviewers would report.To the reviewers
Please read How to review security advisory coverage applications, Application workflow, What to cover in an application review, and Tools to use for reviews.
The important notes are the following.
For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues.
Comment #3
avpadernoUsually, after reviewing a project, we allow the developer to opt projects into security advisory coverage. This project is too small for us and it doesn't contain enough PHP code to really assess your skills as developer.
Have you created any other project on drupal.org (module, theme, distribution) we could instead review? The project needs to have most of the commits (preferable all the commits) done by you.
Comment #4
drubbThanks for taking a look. Yes, there are related projects where most commits are by me:
https://www.drupal.org/project/media_thumbnails
https://www.drupal.org/project/media_thumbnails_pdf
https://www.drupal.org/project/media_thumbnails_svg
The first two have been opted in by a new co-maintainer recently.
Comment #5
rushikesh raval commentedUpdate this application summary for project you want to review for which most of commit done by you.
Comment #6
drubbOk, I've now switched the application to Media Thumbnails SVG:
https://www.drupal.org/project/media_thumbnails_svg
It has a bit more PHP code, but not much more, due to its nature as plugin.
The project with the most code written by me would be https://www.drupal.org/project/media_thumbnails,
but this project already has been opted in for security coverage.
Comment #7
drubbComment #8
rushikesh raval commentedI am changing priority as per Issue priorities.
Comment #9
klausiBoris!!!!! Why are you not approved yet after all those years?
manual review:
The escapeshellarg() calls all look correct to me.
Thanks for your contribution, Boris!
I updated your account so you can opt into security advisory coverage now.
Here are some recommended readings to help with excellent maintainership:
You can find lots more contributors chatting on Slack or IRC in #drupal-contribute. So, come hang out and stay involved!
Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
Thanks to the dedicated reviewer(s) as well.