Problem/Motivation

We want to remove the build files from the repo and allow GitLab to handle packaging them.

Issue fork prototype-3478377

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jldust created an issue. See original summary.

jldust’s picture

jldust commented
Assigned: jldust » pixelwhip

jldust opened merge request !210

jldust opened merge request !211

jldust changed the visibility of the branch 3478377-remove-build-files to hidden.

jldust’s picture

jldust commented
Status: Active » Needs work

I've removed the compiled build files, started to add a .gitlab-ci.yml file, fixed the baseline cypress test, and a few typos.

We still need to:
- Determine if we want to have build package styles after tagging
- Need to start thinking about additional testing & possible demo module for components

grgcrlsn321 made their first commit to this issue’s fork.

grgcrlsn321’s picture

grgcrlsn321 commented
Status: Needs work » Needs review

Removed build files and fixed the following int eh gitlab-ci:

Build Pipeline

- build-assets job: compiles css/js from source during CI
- validate-build-artifacts job: verifies all files were created for build files
- Added build paths to .gitignore file
- Documentation - README explains new developer workflow

Fixed CI Jobs

- phpcs: updated Drupal core constraints
- composer: use artifacts from build job
- cypress - Add testing for prototype theme
- phpstan: updated Drupal core constraints, fixed global function call in generator.php
- cspell: added project words for CI

Cypress Testing:

- Setup PHP 8.4 Composer, MariaDB
- Fixed docker image using Debian with specific packages
- Theme Install: Prototype copies into Drupal and activates
- Generator test - Skipped (too complex for CI)
- Cypress Theme testing for Homepage Loads, Theme is active, CSS files exist, Javascript exists on page, Drupal JS is intialized, and Main Content renders.

pixelwhip made their first commit to this issue’s fork.

jldust’s picture

jldust commented
Status: Needs review » Reviewed & tested by the community

This has been reviewed and will be included in the next tagged release.

  • jldust committed fea3772c on 5.x 
    feat: #3478377 Remove Build Files

By: jldust
By: grgcrlsn321
By:...
jldust’s picture

jldust commented
Status: Reviewed & tested by the community » Fixed

This has been included in the most recent release

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

jldust’s picture

jldust commented
Status: Fixed » Closed (fixed)