Problem/Motivation

The term OPcache should consistently follow its correct capitalization throughout the codebase and documentation. Variations such as "opcache" and "OPCache" are being used, which is inconsistent and can lead to confusion (and may look unprofessional)

Expected behavior

The term should always be written as "OPcache" to maintain proper case usage.

This will improve clarity and ensure consistency in the project's naming conventions.

Source: https://www.php.net/manual/en/book.opcache.php

Issue fork drupal-3478132

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

  • 3478132-move-over Comparechanges, plain diff MR !9748
  • 2 hidden branches
  • 11.x Comparecompare
  • 3478132-fix-case-in Comparecompare

Comments

pere orga created an issue. See original summary.

pere orga’s picture

Version: 11.0.x-dev » 11.x-dev
pere orga’s picture

Issue summary: View changes
Status: Active » Needs review

pere orga changed the visibility of the branch 3478132-fix-case-in to hidden.

cilefen’s picture

Issue summary: View changes
Status: Needs review » Needs work

I say, fix all of them.

quietone’s picture

Issue summary: View changes
Issue tags: +cspell error

Thanks for finding this. I agree that all instances should be fixed in one issue.

pere orga’s picture

Status: Needs work » Needs review

Applied and pushed.

smustgrave’s picture

Status: Needs review » Needs work
Issue tags: +Needs issue summary update

Even if title is clear good practice should be to include full issue summary, using standard template

Also don't see an MR opened, recommend also not using 11.x as a forked branch name

pere orga’s picture

Status: Needs work » Needs review

(edited comment by mistake)

pere orga’s picture

Issue summary: View changes

pere orga changed the visibility of the branch 11.x to hidden.

pere orga’s picture

@smustgrave hopefully should be OK now, MR is https://git.drupalcode.org/project/drupal/-/merge_requests/9729

smustgrave’s picture

How come not attaching the MR to the ticket?

pere orga’s picture

It didn't happen automatically, for some reason. And I don't see how this can be done manually.

cilefen’s picture

Something is odd here.

smustgrave’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs issue summary update +Needs Review Queue Initiative

Fixed the issue. If you follow the issue fork commands above it should attach to the ticket. If you can close your MR though please.

I did do a search for OPCache and opcache and both cases seem to be addressed.

  • quietone committed e43c26dc on 11.x
    Issue #3478132 by pere orga, smustgrave, cilefen: Fix case in comment (...
quietone’s picture

Title: Fix case in comment (OPcache) » Fix case of OPcache in comments
Status: Reviewed & tested by the community » Fixed

Committed e43c26d and pushed to 11.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.