Problem/Motivation

Unable to scroll in project browser interface

Steps to reproduce

  • Install and enable 2.0.0-alpha3 / 2.0.x-dev version of project browser.
  • Go to admin/modules/browse.
  • Click on View commands button to view installation steps for a module.
  • A modal will appear, click cross button on the modal.
  • Observe that scrolling in the interface is no longer possible.

Note: Testing this on google chrome with Mac OS.

Proposed resolution

TBD

Issue fork project_browser-3476400

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

guptahemant created an issue. See original summary.

guptahemant’s picture

guptahemant commented
Version: 2.0.0-alpha3 » 2.0.x-dev
Issue summary: View changes

omkar-pd made their first commit to this issue’s fork.

omkar-pd opened merge request !581

omkar-pd’s picture

omkar-pd commented

Pushed a fix. Test failures aren't related to the changes.

omkar-pd’s picture

omkar-pd commented
Status: Active » Needs review
chrisfromredfin’s picture

chrisfromredfin
he/him/his
Primary language English
Location Portland, Maine
commented
Status: Needs review » Needs work

Need to solve the PHPCS issues.

omkar-pd’s picture

omkar-pd commented

Can we create a new issue to fix phpcs errors? These errors are not introduced in this PR.
I can see phpcs failed in other PRs as well.
https://git.drupalcode.org/issue/project_browser-3464794/-/jobs/2841971

omkar-pd’s picture

omkar-pd commented
Status: Needs work » Needs review

chrisfromredfin’s picture

chrisfromredfin
he/him/his
Primary language English
Location Portland, Maine
commented
Status: Needs review » Fixed

open a new issue, fixed PHPCS errors, rebased this one, tested it - ship it!

omkar-pd’s picture

omkar-pd commented
Status: Fixed » Needs work

@chrisfromredfin,
I just found that this issue reintroduces Remove Modals after They're Closed.

omkar-pd opened merge request !584

omkar-pd’s picture

omkar-pd commented
Status: Needs work » Needs review

This should fix both the issues.
https://git.drupalcode.org/project/project_browser/-/merge_requests/584#...

chrisfromredfin’s picture

chrisfromredfin
he/him/his
Primary language English
Location Portland, Maine
commented
Status: Needs review » Fixed

Thanks, good eye! Merged the latest.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.