GitLab CI reports PHP_CodeSniffer errors/warnings which should be fixed.

Issue fork unstructured-3475952

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

sunil jolapara created an issue. See original summary.

sunil jolapara opened merge request !4

sunil jolapara’s picture

sunil jolapara commented
Status: Needs work » Needs review
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Version: 2.0.0-beta2 » 2.0.x-dev
Assigned: » Unassigned
Status: Needs review » Needs work
Issue tags: +Needs issue summary update

The issue summary for PHP_CodeSniffer issues should always show the report given from PHP_CodeSniffer and the arguments passed to phpcs.

Furthermore, since GitLab CI is now enabled for all the projects, GitLab CI should be used to get PHP_CodeSniffer errors/warnings.

zaryab_drupal’s picture

zaryab_drupal commented
Issue summary: View changes

avpaderno opened merge request !5

avpaderno opened merge request !6

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue summary: View changes
Issue tags: -Needs issue summary update

avpaderno changed the visibility of the branch 3475952-gitlab-ci-reports to hidden.

divyansh.gupta’s picture

divyansh.gupta commented
Assigned: Unassigned » divyansh.gupta

avpaderno opened merge request !7

avpaderno changed the visibility of the branch 3475952-fix-the-phpcodesniffer-issues to hidden.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue tags: +Needs reroll
divyansh.gupta’s picture

divyansh.gupta commented
Assigned: divyansh.gupta » Unassigned
Status: Needs work » Needs review

I have fixed the PHP_CodeSniffer errors and created MR.

kul.pratap’s picture

kul.pratap commented
Status: Needs review » Reviewed & tested by the community

Gitlab CI not showing any phpcs error.
Thank you
Moving it to RTBC+

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Reviewed & tested by the community » Needs work
Issue tags: -Needs reroll
divyansh.gupta’s picture

divyansh.gupta commented
Status: Needs work » Needs review

@avapaderno Made the changes as suggested by you please review.

kalash-j’s picture

kalash-j commented
Status: Needs review » Reviewed & tested by the community

I have applied the MR!7 and there are no errors

scott_euser’s picture

scott_euser commented
Status: Reviewed & tested by the community » Needs work
  1. There is an unaddressed comment (ie, scope creep beyond just fixing the errors)
  2. We should add default gitlab-ci.yaml so the phpcs pipeline actually runs to confirm the firm
scott_euser’s picture

scott_euser commented
Title: Fix the issues reported by PHP_CodeSniffer » Fix the issues reported by phpcs, phpstan, cspell
Status: Needs work » Needs review

Okay all resolved, including conflicts from 2.0.x branch

@avpaderno the merge is blocked by unresolved comments, but I have checked and @divyansh.gupta addressed them. I am unable to mark them as resolved myself. Can you please do?

paraderojether’s picture

paraderojether commented
Status: Needs review » Reviewed & tested by the community

Hi

I reviewed MR!7, and confirmed phpcs, phpstan, cspell are now passed on the Gitlab CI.

Moving this to RTBC.
Thank you.

scott_euser’s picture

scott_euser commented
Status: Reviewed & tested by the community » Fixed

Thanks everyone!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.