Bump phpstan/phpstan to 1.12.4 to make daily "updated deps" QA run pass again

Personally I believe `vfs` streams are intended to be non-existing and shouldn't be flagged by PHPStan, but more on that in the follow-up #3475920: Handle PHPStan baseline additions about vfs

Well, I'm hoping the upgrade to composer/composer that just landed fixes the composer update issue in the scheduled "updated deps"-runs, since that has been failing for about 2 weeks now with:

$ if [ -n "$COMPOSER_UPDATE" ]; then composer update --optimize-autoloader; composer outdated; fi
> Drupal\Composer\Composer::ensureComposerVersion
Loading composer repositories with package information
Updating dependencies
Your requirements could not be resolved to an installable set of packages.
  Problem 1
    - Root composer.json requires drupal/core 11.0.x-dev (exact version match), it is satisfiable by drupal/core[11.0.x-dev] from composer repo (https://repo.packagist.org) but drupal/core[dev-main] from path repo (core) has higher repository priority. The packages from the higher priority repository do not match your constraint and are therefore not installable. That repository is canonical so the lower priority repo's packages are not installable. See https://getcomposer.org/repoprio for details and assistance.
  Problem 2
    - Root composer.json requires drupal/core-project-message 11.0.x-dev (exact version match), it is satisfiable by drupal/core-project-message[11.0.x-dev] from composer repo (https://repo.packagist.org) but drupal/core-project-message[dev-main] from path repo (composer/Plugin/ProjectMessage) has higher repository priority. The packages from the higher priority repository do not match your constraint and are therefore not installable. That repository is canonical so the lower priority repo's packages are not installable. See https://getcomposer.org/repoprio for details and assistance.
  Problem 3
    - Root composer.json requires drupal/core-vendor-hardening 11.0.x-dev (exact version match), it is satisfiable by drupal/core-vendor-hardening[11.0.x-dev] from composer repo (https://repo.packagist.org) but drupal/core-vendor-hardening[dev-main] from path repo (composer/Plugin/VendorHardening) has higher repository priority. The packages from the higher priority repository do not match your constraint and are therefore not installable. That repository is canonical so the lower priority repo's packages are not installable. See https://getcomposer.org/repoprio for details and assistance.

I don't _think_ the dependency composer will fix our actual-composer-on-the-test-runner problem, but as a hail mary, it's all I've got.

Can't reproduce any of the above locally.

Looks to me "somehow" the self.version from the above packages lost all its meaning during the update, and composer lands on the if-all-else-fails-fallthrough of dev-main.

Without a fix on the above fixing this issue is basically moot.

Interesting, thanks @longwave!

Not sure it's exactly the same issue, but at least it gives me/us some pointers on where to look for problems/fixes within composer itself.

Rebased the MR, back to RTBC.

The actual run with updated deps still fails, but that's something for a new issue IMHO.

Sad panda did rebase, all seems well now.

BTW: I had to run a few test-jobs multiple times to get them passing.
Is there a known increase in random test failures lately?

Thanks @catch.

I've got some free time (Mwuahah!), I'll try to, at the very least, create issues for some reoccurring ones.

I was just about to comment that it would surprise me if those two additions to the baseline just vanished, but saw that GitLab CI agrees with me, they're still needed.

 ------ ------------------------------------------------------------------------ 
  Line   core/tests/Drupal/Tests/Core/Update/UpdateRegistryTest.php              
 ------ ------------------------------------------------------------------------ 
  244    Path in include_once()                                                  
         "vfs://drupal/sites/default/modules/module_a/module_a.post_update.php"  
         is not a file or it does not exist.                                     
  245    Path in include_once()                                                  
         "vfs://drupal/sites/default/modules/module_b/module_b.post_update.php"  
         is not a file or it does not exist.                                     
 ------ ------------------------------------------------------------------------ 
 [ERROR] Found 2 errors   

https://git.drupalcode.org/project/drupal/-/pipelines/306083

So I'm afraid we now have a broken 11.x HEAD?
Unsure what status this should have, but I've put the version back to 11.x

(Did you perhaps forgot a composer update somewhere in your procedure to create the new baseline?)

The 10.4.x branch has a lot more changes in the PHPStan baseline.

I vaguely remember creating an issue about the invalidPregQuote errors that landed in 11.x-land, but wasn't backported to 10.4.x IIRC.

Thanks @rpayanm for merging the latest of 10.4.x back into this MR.

I think this issue is cursed, first the broken HEAD on 11.x and now I somehow managed to create a 10.4.x MR twice without getting it to use the HEAD of that branch, even after I've update fork drupal-3475916.

On top of that, it seems the HEAD of 10.4.x is broken (and let the records show I had nothing to with it ;)

Asked about it in Slack: https://drupal.slack.com/archives/C079NQPQUEN/p1728647212972519

Postponed on #3480180: Recipe validation error in 10.4.x

Unblocked.

How about no...