10.4.x tests are currently failing, RecipeQuickStartTest fails with
Validation errors were found in core/recipes/feedback_contact_form/recipe.y \n
ml: \n
- [input]: This value should be of type associative_array. \n
- [input][recipient][constraints]: This value should be of type associative \n
_array. \n
- [input][recipient][prompt][arguments]: This value should be of type assoc \n
iative_array. \n
- [input][recipient][default][config]: This value should be of type list. \n
I think this is since #3303126: Make it possible for recipes to prompt for input values was committed to 10.4.x, but strangely it doesn't show as committed in the issue, and the commit happened a month ago but the push/pipeline run was only 3 days ago?
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | 3480180-nr-bot.txt | 90 bytes | needs-review-queue-bot |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes, plain diff MR !9823
Comments
Comment #2
alexpottYeah I backported #3303126: Make it possible for recipes to prompt for input values to 10.4.x only recently. Let's fix this here.
Comment #4
alexpottThis is all my bad.
We need to backport #3303127: Determine which core config entity methods should be config actions as well. Plus there are new things in Symfony constraints we're using in 11.x that we can't use on 10.4.x. Created an MR to resolve all this. I should have been concentrating on backporting these things to 10.4.x to keep recipes aligned as much as possible for 11.x and 10.4.x so we have cross compatibilty.
Comment #5
alexpottAdd we should backport to #3448131: Create flexible config actions to place a block in the admin or default themes too...
The MR includes the fix for Symfony and cherry-picks for the 2 missing issues.
Comment #6
needs-review-queue-bot commentedThe Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.
Comment #7
longwaveComment #8
longwaveNW for multiple test failures.
Comment #9
alexpottOkay I've fixed up the kernel test that needs fixing and also backported #3302833: Improve PluginNotFound exception to include possible shorthand action IDs to 10.4.x
I'm going to do the cherry-picks back to 10.4.x and rebase this so it contains only the necessary fixes.
Comment #10
catchOK what's here seems pretty minimal now, let's get this in to unbreak HEAD?
Comment #12
longwaveCommitted dee8d88 and pushed to 10.4.x. Thanks!