This is a follow-up issue of #3228379: Download errors, backup files contain trailing HTML, corrupts archive backups. In that issue, we found out that when doing an advanced backup and checking "Take site offline" and selecting "Download" as the destination, the backup will download, but the site won't leave maintenance mode automatically.
For the time being, we introduced a validation error, when both options are checked, but this should be fixed at its root.
Find the root cause, why the site won't leave maintenance mode after doing a backup using the "Download" destination, fix it and remove the validation error.
Comments
Comment #2
grevil commentedThe problem of this lies in "/src/Drupal/Destination/DrupalBrowserDownloadDestination.php". The
exit()call will stop further code from executing (including taking the site out of maintenance mode). Removing theexit()call will break the module though (see #3228379: Download errors, backup files contain trailing HTML, corrupts archive backups). So we might need to take the site online, before callingexit()!Comment #3
grevil commentedLet us also add tests, to check if the created backup file is NOT broken.
Comment #4
anybody