GitLab CI reports PHP_CodeSniffer errors/warnings which should be fixed.

Issue fork sector_social_follow-3472719

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

sunil jolapara created an issue. See original summary.

avpaderno made their first commit to this issue’s fork.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Version: 1.0.0-alpha4 » 1.0.x-dev
Status: Needs work » Active

avpaderno opened merge request !2

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue summary: View changes
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Priority: Normal » Minor
Status: Active » Needs review
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Title: Fix the PHP_CodeSniffer issues » Fix the issues reported by PHP_CodeSniffer
cleavinjosh’s picture

cleavinjosh commented
Status: Needs review » Needs work

Hi @avpaderno,

I applied MR!2, it was applied smoothly and fixed most of the phpcs issues.

These are the remaining issues after I ran phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml:

➜  sector_social_follow git:(1.0.x) curl https://git.drupalcode.org/project/sector_social_follow/-/merge_requests/2.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  2445    0  2445    0     0   5108      0 --:--:-- --:--:-- --:--:--  5104
patching file .gitlab-ci.yml
patching file sector_social_follow.install
➜  sector_social_follow git:(1.0.x) ✗ ..
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml sector_social_follow

FILE: /Users/interns/Demo-site/drupal_11_test/install-dir/drupal_11_test_site/web/modules/contrib/sector_social_follow/sector_social_follow.info.yml
----------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
----------------------------------------------------------------------------------------------------------------------------------------------------
  1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
  9 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:"
 10 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:"
 11 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:"
----------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/interns/Demo-site/drupal_11_test/install-dir/drupal_11_test_site/web/modules/contrib/sector_social_follow/sector_social_follow.install
---------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------------------
 13 | ERROR | [x] You must use "/**" style comments for a function comment
---------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/interns/Demo-site/drupal_11_test/install-dir/drupal_11_test_site/web/modules/contrib/sector_social_follow/README.md
--------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
--------------------------------------------------------------------------------------------------------------------------------
  3 | WARNING | Line exceeds 80 characters; contains 161 characters
  8 | WARNING | Line exceeds 80 characters; contains 234 characters
  9 | WARNING | Line exceeds 80 characters; contains 84 characters
 20 | WARNING | Line exceeds 80 characters; contains 122 characters
--------------------------------------------------------------------------------------------------------------------------------

Time: 163ms; Memory: 10MB

➜  contrib git:(main) ✗

Additionally, GitLab CI also found some errors.

Please check and advise.
Thank you.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs work » Needs review

The only error reported by GitLab CI is the following one.

FILE: ...b/modules/custom/sector_social_follow-3472719/sector_social_follow.install
-------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------
 13 | ERROR | [x] You must use "/**" style comments for a function comment
    |       |     (Drupal.Commenting.FunctionComment.WrongStyle)
-------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------
Time: 100ms; Memory: 6MB

 

I deleted that documentation comment and rewrote it.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

GiLab CI no longer reports PHP_CodeSniffer errors/warnings.

stewest made their first commit to this issue’s fork.

stewest opened merge request !3

stewest’s picture

stewest
Location Wellington
commented
Status: Needs review » Reviewed & tested by the community

Looking good. Thank you!

stewest’s picture

stewest
Location Wellington
commented
Status: Reviewed & tested by the community » Fixed

Releasing a new version

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.