Overview

Currently, if you drag an element which has children, it is possible to drag the parent element as a child of itself.

Proposed resolution

It should not be possible to drag an element into itself. The UX should highlight that the whole tree is being moved, and should prevent the parent from being moved inside itself.

User interface changes

CommentFileSizeAuthor
#7 console-error.png406.87 KBbhuvaneshwar
#7 BE-error.png154.88 KBbhuvaneshwar
#5 Untitled.gif336.49 KBgauravvvv
CleanShot 2024-09-06 at 09.28.45.gif575.74 KBlauriii

Issue fork experience_builder-3472500

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

lauriii created an issue. See original summary.

fazilitehreem’s picture

fazilitehreem commented
Assigned: Unassigned » fazilitehreem
fazilitehreem’s picture

fazilitehreem commented
Assigned: fazilitehreem » Unassigned
gauravvvv’s picture

gauravvvv commented
Assigned: Unassigned » gauravvvv
gauravvvv’s picture

gauravvvv commented
Assigned: gauravvvv » Unassigned
StatusFileSize
new Untitled.gif336.49 KB

The issue is no longer reproducible.

bhuvaneshwar made their first commit to this issue’s fork.

bhuvaneshwar’s picture

bhuvaneshwar commented
Assigned: Unassigned » bhuvaneshwar
StatusFileSize
new BE-error.png154.88 KB
new console-error.png406.87 KB

I was able to reproduce the issue and have started making progress on it.

getting an error when dragging component into itself

Console error

BE Error

bhuvaneshwar’s picture

bhuvaneshwar commented

Hi @lauriii, just to confirm, we cannot drag the column_one component into its child components like images or text. However, we are able to drag the main two-column parent component under column_one. Can the same structure be applied to the main parent component?

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented

The column_one is a slot which means it should never be possible to drag that anywhere. The main component "Two column" should be draggable but it should act like a tree so that everything inside gets dragged with it, and you should not be able to drag the main component inside its own slots. It should be possible to drag components into slots like the column_one.

bhuvaneshwar opened merge request !315

bhuvaneshwar’s picture

bhuvaneshwar commented
Assigned: bhuvaneshwar » Unassigned
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Issue tags: +Novice
Parent issue: » #3450592: [META] Front-end Kanban issue tracker
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Issue tags: +DrupalCon Barcelona 2024
hooroomoo’s picture

hooroomoo
they/them
Location nyc🗽
commented

#3470594: Refine dragging behavior and design in Layers menu addresses this. There are several bugs with the current layers menu that #3470594: Refine dragging behavior and design in Layers menu fixes.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Assigned: Unassigned » hooroomoo
Status: Active » Postponed (maintainer needs more info)
Issue tags: -DrupalCon Barcelona 2024

@hooroomoo Oh! So is this … a duplicate/obsolete?

hooroomoo’s picture

hooroomoo
they/them
Location nyc🗽
commented
Assigned: hooroomoo » Unassigned

Yeah I'd say duplicate.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Postponed (maintainer needs more info) » Closed (duplicate)
Parent issue: #3450592: [META] Front-end Kanban issue tracker »
Related issues: +#3470594: Refine dragging behavior and design in Layers menu

🥳