Problem/motivation
Autocomplete fields are using an older-style icon to identify fields as such. Claro theme uses a magnifying glass icon for these fields. To maintain consistency, Linkit should follow suit.
Steps to reproduce
- install vanilla Drupal 11
- add an entity reference field to a content type
- observe the field uses a magnifying glass icon to indicate it being an autocomplete field.
Conversely:
- add Linkit module
- create a link field that allows internal links
- observe the field uses a gray circle to indicate it being an autocomplete field.
Proposed resolution
Follow what Claro uses for consistency.
![]()
This module uses Gitlab CI for automated testing of proposed code changes. To contribute code changes, create a merge request. Patch files will not trigger automated testing and are not sufficient for review.
| Comment | File | Size | Author |
|---|
Issue fork linkit-3472411
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
byronveale commentedI created a merge request where the “throbber” icons have been replaced with Claro’s magnifying glass icons. I also updated the helper text in an attempt to add clarity.
Attaching a patch generated from this merge request.
Comment #4
byronveale commentedUpdated patch after fixing test.
Comment #5
mark_fullmerComment #6
byronveale commentedComposer choked on patch generated from issue fork. Attaching new one that composer liked which was generated using patch utility.
Comment #7
idebr commented#3088314: Implement js- prefix for linkit textfields to separate JavaScript behavior from styling essentially does the same, but without duplicating Claro CSS
Comment #8
nils.destoop commentedUpdated patch for latest 7.x
Comment #9
bkosbornelooks good to me!
Comment #10
bkosborneNevermind, the latest patch breaks things. The linkit autocomplete isn't used at all with it. Needs some work.
Comment #11
bkosbornePatch from #8 appeared to have unrelated changes. I just updated the merge request to be compatible with latest from 7.x and hid the patch files.
Please, use MR updates for future updates, not patch files.
Comment #12
idebr commentedIcon looks much better now, thanks!
Comment #14
mark_fullmerEverything looks good. Thanks, everyone!