Problem/motivation

Autocomplete fields are using an older-style icon to identify fields as such. Claro theme uses a magnifying glass icon for these fields. To maintain consistency, Linkit should follow suit.

Steps to reproduce

  1. install vanilla Drupal 11
  2. add an entity reference field to a content type
  3. observe the field uses a magnifying glass icon to indicate it being an autocomplete field.

Conversely:

  1. add Linkit module
  2. create a link field that allows internal links
  3. observe the field uses a gray circle to indicate it being an autocomplete field.

Proposed resolution

Follow what Claro uses for consistency.

autocomplete field in standard Drupal installation showing magnifying glass icon

This module uses Gitlab CI for automated testing of proposed code changes. To contribute code changes, create a merge request. Patch files will not trigger automated testing and are not sufficient for review.

Issue fork linkit-3472411

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

byronveale created an issue. See original summary.

byronveale’s picture

StatusFileSize
new6.95 KB

I created a merge request where the “throbber” icons have been replaced with Claro’s magnifying glass icons. I also updated the helper text in an attempt to add clarity.

Attaching a patch generated from this merge request.

byronveale’s picture

Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new8.3 KB

Updated patch after fixing test.

mark_fullmer’s picture

Title: Improve autocomplete UI » Match autocomplete icon to Claro autocomplete
byronveale’s picture

StatusFileSize
new5.15 KB

Composer choked on patch generated from issue fork. Attaching new one that composer liked which was generated using patch utility.

nils.destoop’s picture

StatusFileSize
new3.48 KB

Updated patch for latest 7.x

bkosborne’s picture

Status: Needs review » Reviewed & tested by the community

looks good to me!

bkosborne’s picture

Status: Reviewed & tested by the community » Needs work

Nevermind, the latest patch breaks things. The linkit autocomplete isn't used at all with it. Needs some work.

bkosborne’s picture

Status: Needs work » Needs review

Patch from #8 appeared to have unrelated changes. I just updated the merge request to be compatible with latest from 7.x and hid the patch files.

Please, use MR updates for future updates, not patch files.

idebr’s picture

Status: Needs review » Reviewed & tested by the community

Icon looks much better now, thanks!

  • mark_fullmer committed 674e1c25 on 7.x
    Issue #3472411 by byronveale, bkosborne, nils.destoop, idebr,...
mark_fullmer’s picture

Status: Reviewed & tested by the community » Fixed

Everything looks good. Thanks, everyone!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.