Problem/Motivation

The pagination label not changing by source on every source it is saying "Modules per page".
pagination-label-project-browser

Steps to reproduce

  1. Install the Project Browser (2.x version, I did not test with 1.x but I am sure it must be in that one also)
  2. Go to the Project browser settings /admin/config/development/project_browser and enable at least 2 sources like Drupal.org (JSON:API)and Recipes
  3. Visit the /admin/modules/browsepage
  4. Click on Drupal.org (JSON:API)tab and scroll down to the pagination label which is Modules per pagecorrect in this case because the results in this tab are only modules.
  5. Click on Recipestab and scroll down to the pagination label which is stillModules per pageand that is incorrect because in this case because the results in this tab are not modules.

Proposed resolution

  1. Either change the label per source like "Modules per page", "Recipes per page"
  2. or make it generic like "Results per page" or "Items per page" because I think the pagination configuration is same across sources so this one will make more sense.
CommentFileSizeAuthor
pagination-label-project-browser.gif6.53 MBprashant.c

Issue fork project_browser-3472230

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

prashant.c created an issue. See original summary.

prashant.c’s picture

prashant.c
he/him
Primary language English
Location Dharamshala
commented
Issue summary: View changes
atul_ghate’s picture

atul_ghate commented
Assigned: Unassigned » atul_ghate

atul_ghate opened merge request !572

atul_ghate’s picture

atul_ghate commented
Status: Active » Needs review

For now, I have changed the pagination label to 'Items per page' as it seems more generic. Please provide feedback if any dynamic labeling is required based on the selected tab.

prashant.c’s picture

prashant.c
he/him
Primary language English
Location Dharamshala
commented
Status: Needs review » Needs work

@atul_ghate

Thanks for working on this, let us wait for review(s) from someone else as well. Meanwhile, you may want to check why some Functional tests are failing.

atul_ghate’s picture

atul_ghate commented
Status: Needs work » Needs review

chrisfromredfin made their first commit to this issue’s fork.

chrisfromredfin’s picture

chrisfromredfin
he/him/his
Primary language English
Location Portland, Maine
commented
Status: Needs review » Fixed

thanks!

I would love to see some of this energy put on some existing issues in addition to self-generated ones.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.