Problem/Motivation
Proposed resolution
Remove use of this setting.
Remaining tasks
Figure out how to remove it. Implement.
User interface changes
None.
API changes
None.
Data model changes
None.
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | 3472124-08.patch | 3.99 KB | joseph.olstad |
Comments
Comment #2
joseph.olstadThis should actually go into the 6.0.x branch which hasn't yet been created.
Comment #3
liam morlandThis change doesn't have to wait until Drupal 11. It can happen anytime that the minimum is Drupal 10.2
Comment #4
smulvih2This makes sense to include in the 5.2.x branch and the new 5.3.x branch (still in testing).
Comment #5
joseph.olstadFrom my searches of our code base, this change requirement is appears to be possibly quite extensive and non-trivial.
Perhaps target this for 5.3.x instead of 5.2.x with option of deferring to 6.0.x
Comment #6
liam morlandActually, this is not a change for Drupal 11. The change happened in Drupal 10.2. It looks like the setting didn't work so they just removed it. The setting can probably just be removed from the Views. The change was in commit f890b7f.
Comment #7
joseph.olstadah ok, I'm not aware of anything terribly broken in 5.2.x relating to this however ya, I seems to recall possibly seeing reminents of this in config export diffs.
Comment #8
joseph.olstadOk, if it's just this, then it's trivial.
There may be more to this however.
Comment #9
joseph.olstad@smulvih2,
please review patch
Comment #10
joseph.olstadYa, I had another look at the change notice, this is something trivial, just some cleanup for a D7 views attribute that was never working in D8+ views.
thanks @liam morland.
Related change notice
see patch 8 above
Comment #11
joseph.olstadactually, one more patch
Comment #12
joseph.olstadah, excuse me, ya it really is that simple.
Comment #14
smulvih2@liam good catch on this deprecation, and thanks for the patch @joseph! This has been merged with 5.3.x