Problem/Motivation

The Views setting default_argument_skip_url has been removed from all Views contextual filter settings.

Proposed resolution

Remove use of this setting.

Remaining tasks

Figure out how to remove it. Implement.

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#8 3472124-08.patch3.99 KBjoseph.olstad

Comments

liam morland created an issue. See original summary.

joseph.olstad’s picture

This should actually go into the 6.0.x branch which hasn't yet been created.

liam morland’s picture

This change doesn't have to wait until Drupal 11. It can happen anytime that the minimum is Drupal 10.2

smulvih2’s picture

This makes sense to include in the 5.2.x branch and the new 5.3.x branch (still in testing).

joseph.olstad’s picture

From my searches of our code base, this change requirement is appears to be possibly quite extensive and non-trivial.

Perhaps target this for 5.3.x instead of 5.2.x with option of deferring to 6.0.x

liam morland’s picture

Issue summary: View changes

Actually, this is not a change for Drupal 11. The change happened in Drupal 10.2. It looks like the setting didn't work so they just removed it. The setting can probably just be removed from the Views. The change was in commit f890b7f.

joseph.olstad’s picture

ah ok, I'm not aware of anything terribly broken in 5.2.x relating to this however ya, I seems to recall possibly seeing reminents of this in config export diffs.

joseph.olstad’s picture

StatusFileSize
new3.99 KB

Ok, if it's just this, then it's trivial.
There may be more to this however.

joseph.olstad’s picture

Assigned: Unassigned » smulvih2
Status: Active » Needs review

@smulvih2,
please review patch

joseph.olstad’s picture

Ya, I had another look at the change notice, this is something trivial, just some cleanup for a D7 views attribute that was never working in D8+ views.

thanks @liam morland.

Related change notice
see patch 8 above

joseph.olstad’s picture

Assigned: smulvih2 » joseph.olstad

actually, one more patch

joseph.olstad’s picture

Assigned: joseph.olstad » smulvih2

  • smulvih2 committed 591894c4 on 5.3.x
    Issue #3472124 by joseph.olstad, liam morland: Remove...
smulvih2’s picture

Version: 5.2.x-dev » 5.3.x-dev
Status: Needs review » Fixed

@liam good catch on this deprecation, and thanks for the patch @joseph! This has been merged with 5.3.x

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.