Problem/Motivation

Remove calls to deprecated file_validate().

Remaining tasks

Implement.

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#11 wxt-file-validate-deprecated-3472120-11.patch2.05 KBsmulvih2

Comments

liam morland created an issue. See original summary.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Parent issue: » #3466676: Drupal 11 preparedness
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Assigned: Unassigned » joseph.olstad
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Active » Fixed

Fixed in 5.3.x

https://git.drupalcode.org/project/wxt/-/commit/d82c0488f

Creditted also.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Assigned: joseph.olstad » smulvih2

@smulvih2, please push this to upstream

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Fixed » Reviewed & tested by the community

needs to be pushed into github upstream

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Status: Reviewed & tested by the community » Needs work

There is another call in modules/custom/wxt_ext/wxt_ext_media/src/Element/Upload.php.

  • joseph.olstad committed 99cc0c5a on 5.3.x 
    Issue #3472120 by liam morland, joseph.olstad: Remove calls to...
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Needs work » Reviewed & tested by the community

Oh thanks yes I missed that, here it is: https://git.drupalcode.org/project/wxt/-/commit/99cc0c5a77

smulvih2’s picture

smulvih2
Location Canada 🍁
commented
StatusFileSize
new wxt-file-validate-deprecated-3472120-11.patch2.05 KB

Adding patch for these changes so they can be easily added to any branch, like 5.2.x.

smulvih2’s picture

smulvih2
Location Canada 🍁
commented

I have pushed this fix to 5.3.x in GitHub. There is no official 5.3.x release yet (not sure how this got into GitLab). Have done a lot of testing on 5.3.x so there will be a release very shortly. Thanks!

  • smulvih2 committed a2a35a1f on 5.3.x 
    Issue #3472120 by joseph.olstad, liam morland: Remove calls to...
smulvih2’s picture

smulvih2
Location Canada 🍁
commented
Status: Reviewed & tested by the community » Fixed

This is now available in the new dev release 5.3.x

smulvih2’s picture

smulvih2
Location Canada 🍁
commented
Version: 5.2.x-dev » 5.3.x-dev

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

We made the above changes but didn't fully integrate the required changes as required by the related change notice.

This was fixed recently in 6.1.x and 5.4.x

https://github.com/drupalwxt/wxt/pull/313

and also

this related patch was added for entity_browser to fix a related bug

https://git.drupalcode.org/project/wxt/-/blob/6.1.x/composer.json#L272

*** Latest 5.4.x dev and latest 6.1.x dev have all of these fixes! ***