Problem/Motivation

In #3291299: Log errors caught by HttpController, we started logging errors. However, preflight errors are not currently being logged.

For example, there are some test failures right now in #3471349: Add types for properties and arguments, but because these errors occur in the preflight check, they don't get logged,

For example:

Error: Typed property Drupal\jsonrpc\Object\Response::$resultSchema must not be accessed before initialization in Drupal\jsonrpc\Object\Response->getResultSchema() (line 174 of /var/www/html/web/modules/contrib/jsonrpc/src/Object/Response.php).

Let's add logging for these, too, so that admins can be alerted if requests are failing.

In addition, the module is currently logging to the php channel. Let's use a jsonrpc channel instead to make it easier to filter the logs generated by this module.

Issue fork jsonrpc-3471857

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

ptmkenny created an issue. See original summary.

ptmkenny’s picture

Issue summary: View changes
ptmkenny’s picture

Status: Active » Needs review
bradjones1’s picture

Status: Needs review » Reviewed & tested by the community

Made a few notes, very minor. I think this is generally RTBC.

ptmkenny’s picture

  • ptmkenny committed 32de42ef on 2.x
    Issue #3471857 by ptmkenny, bradjones1: Log preflight errors, and use...
ptmkenny’s picture

Status: Reviewed & tested by the community » Fixed

Thanks for the review!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.