Problem/Motivation

Now that the GitLab CI template has been committed, let's fix the issues identified by phpstan:

 ------ ---------------------------------------------------------------------- 
  Line   src/Annotation/JsonRpcMethod.php                                      
 ------ ---------------------------------------------------------------------- 
  124    \Drupal calls should be avoided in classes, use dependency injection  
         instead                                                               
 ------ ---------------------------------------------------------------------- 
 ------ ---------------------------------------------------- 
  Line   src/Controller/HttpController.php                   
 ------ ---------------------------------------------------- 
  91     Call to an undefined static method                  
         Drupal\Core\Cache\CacheableJsonResponse::create().  
  138    Call to an undefined static method                  
         Drupal\Core\Cache\CacheableJsonResponse::create().  
  188    Undefined variable: $content                        
 ------ ----------------------------------------------------

Issue fork jsonrpc-3471329

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

ptmkenny created an issue. See original summary.

ptmkenny opened merge request !14

ptmkenny’s picture

ptmkenny commented
Status: Active » Needs review
ptmkenny’s picture

ptmkenny commented

I'll fix the current phpstan issues here, and the D11 issues in the upgrade to D11 issue.

ptmkenny’s picture

ptmkenny commented

  • ptmkenny committed a1f2f311 on 2.x 
    Issue #3471329 by ptmkenny: Fix phpstan issues
ptmkenny’s picture

ptmkenny commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.