Overview

The pinch to zoom pattern is supported by Figma and most of the page builders. This is something that at least I'm accustomed to using when working on a laptop.

Proposed resolution

Allow zooming the canvas by pinching on touchpad.

User interface changes

Issue fork experience_builder-3469670

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

lauriii created an issue. See original summary.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Title: Allow zooming the canvas by pinching on touchpad » Allow zooming the canvas by pinching on a touchpad
Parent issue: » #3450592: [META] Front-end Kanban issue tracker
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Related issues: +#3463307: Implement simplified zoom interface

This might be impacted by #3463307: Implement simplified zoom interface.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Category: Task » Bug report

Pinching sort of works now that #3463307: Implement simplified zoom interface was committed. There's still some problems where occasionally the pinch is actually captured by the browsers, leading into the whole app zooming in. I wonder if #3469673: Keyboard commands to zoom in and out should only impact the preview canvas would address this?

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Related issues: +#3469673: Keyboard commands to zoom in and out should only impact the preview canvas

gauravvvv made their first commit to this issue’s fork.

gauravvvv’s picture

gauravvvv commented
Assigned: Unassigned » gauravvvv

gauravvvv opened merge request !291

gauravvvv’s picture

gauravvvv commented
Assigned: gauravvvv » Unassigned
Status: Active » Needs review
jessebaker’s picture

jessebaker commented
Status: Needs review » Needs work

Hi @gauravvvv I gave this a quick test but I can't seem to determine what difference is made by the addition of this code? Can you give a short summary of what the code is intended to do?

As @lauriii mentioned, it is already possible to zoom with a pinch gesture (although there are bugs).

jessebaker’s picture

jessebaker commented
Version: » 0.x-dev
Status: Needs work » Closed (outdated)

Fixed in #3475759: Implement a different approach to the iFrame preview interactions