Follow up from #3465510: Fix: The update to convert "numeric" arguments to "entity_target_id" is deprecated

The same issue is present in promotion submodule. Deprecation:

The update to convert "numeric" arguments to "entity_target_id" for entity reference fields for view "commerce_promotion_coupons" is deprecated in drupal:10.3.0 and is removed from drupal:12.0.0. Profile, module and theme provided configuration should be updated. See https://www.drupal.org/node/3441945

CommentFileSizeAuthor
#8 3469240-8.patch4.61 KBkeshavv
#4 3469240-deprecation-fix-2.x.patch698 bytesducktape

Issue fork commerce-3469240

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

ducktape created an issue. See original summary.

ducktape opened merge request !311

ducktape’s picture

ducktape commented
Related issues: +#3465510: Fix: The update to convert "numeric" arguments to "entity_target_id" is deprecated
ducktape’s picture

ducktape commented
StatusFileSize
new 3469240-deprecation-fix-2.x.patch698 bytes

Added the fix as a MR for 3.0.x.

Added a patch for 2.x for who might need it in their workflow.

ducktape’s picture

ducktape commented
Issue summary: View changes
ducktape’s picture

ducktape commented
Status: Active » Needs review
jsacksick’s picture

jsacksick commented

hm... Then we have the same issue with other views? We have 10 occurrences of plugin_id: numeric in the current codebase?

keshavv’s picture

keshavv commented
StatusFileSize
new 3469240-8.patch4.61 KB
jsacksick’s picture

jsacksick commented
Title: Promotion: The update to convert "numeric" arguments to "entity_target_id" is deprecated » The update to convert "numeric" arguments to "entity_target_id" is deprecated
Issue tags: +Release blocker
zaporylie’s picture

zaporylie
he/him
Primary language Polish
commented
Status: Needs review » Needs work

We need a update_hook_N similar to what was done in https://git.drupalcode.org/project/commerce/-/merge_requests/300/diffs#8... to update views on existing commerce instances if they were not customized by site admin.

zaporylie’s picture

zaporylie
he/him
Primary language Polish
commented
Issue summary: View changes
jsacksick’s picture

jsacksick commented

As discussed on Slack, let's check how core handled this, and let's open a followup issue for the update hook.

  • jsacksick committed 41ea9def on 3.0.x 
    Issue #3469240 by ducktape, keshavv, jsacksick, zaporylie: The update to...
jsacksick’s picture

jsacksick commented
Issue tags: -Release blocker +needs update hook

Committed the patch so the views are at least correct on news installs, but we still need to take care of the update hook.

jsacksick’s picture

jsacksick commented
Status: Needs work » Closed (outdated)

jsacksick closed merge request !311