Problem/Motivation

This issue is for imalabya to test the SDC conversion script and the guide using:

  • demo_design_system/components/01-atoms/video

Steps to reproduce

Proposed resolution

Go through the conversion guide and try to convert the component using the script and report any feedback.

Remaining tasks

  • Review guide
  • Follow guide to use the script
  • Convert demo_design_system/components/01-atoms/video
  • Report feedback here

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#4 Screenshot 2024-08-15 at 12.55.52 PM.png121.34 KBimalabya
#4 Screenshot 2024-08-15 at 12.55.37 PM.png120.59 KBimalabya

Issue fork demo_design_system-3468118

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Kristen Pol created an issue. See original summary.

imalabya’s picture

imalabya
Primary language English
Location Bangalore
commented
Assigned: Unassigned » imalabya

imalabya opened merge request !17

imalabya’s picture

imalabya
Primary language English
Location Bangalore
commented
Assigned: imalabya » Unassigned
Status: Active » Needs review
StatusFileSize
new Screenshot 2024-08-15 at 12.55.37 PM.png120.59 KB
new Screenshot 2024-08-15 at 12.55.52 PM.png121.34 KB

@Kristen Pol Below are the findings

- Used the conversion script to generate the yml file and README.md
- The video.component.yml & README.md file were generated inside demo_design_system/components/01-atoms/video
- Copied the demo_design_system/components/01-atoms/video to demo_design_system/starshot_demo/components/01-atoms/video
- Verified the SDC component in the SDC Registry

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Status: Needs review » Needs work

Thanks!

Note: The video component doesn't need to be added to the starshot_demo subtheme.

Also, can you compare your work against the recent dev changes? There was recently a commit of all baseline yaml and readme files. It would be helpful to compare your results against that to see if they align or the files should be updated with some of your suggestions

imalabya’s picture

imalabya
Primary language English
Location Bangalore
commented
Status: Needs work » Needs review

@kristen pol Removed the component from the starshot_demo subtheme.

The recent dev changes have made the title, sources, poster, width, height & fallback_text the required prop in the component.yml for iframe. IMO, it should be the sources. Updated the MR with the same.

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Status: Needs review » Fixed

Thanks. I agree and have updated the required fields.

kristen pol closed merge request !17

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.