Problem/Motivation

This issue is for imalabya to test the SDC conversion script and the guide using:

  • demo_design_system/components/01-atoms/image

Steps to reproduce

Proposed resolution

Go through the conversion guide and try to convert the component using the script and report any feedback.

Remaining tasks

  • Review guide
  • Follow guide to use the script
  • Convert demo_design_system/components/01-atoms/image
  • Report feedback here

User interface changes

API changes

Data model changes

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Kristen Pol created an issue. See original summary.

imalabya’s picture

Assigned: Unassigned » imalabya

imalabya’s picture

Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new123.29 KB

@Kristen Pol Below are the findings

- Reviewed the SDDS SDC conversion guide
- Used the conversion script to generate the yml file and README.md
- The image.component.yml & README.md file were generated inside demo_design_system/components/01-atoms/image
- Copied the demo_design_system/components/01-atoms/image to demo_design_system/starshot_demo/components/01-atoms/image
- Verified the SDC component in SDC Registry

imalabya’s picture

Assigned: imalabya » Unassigned
kristen pol’s picture

Assigned: Unassigned » kristen pol

Assigning to myself

kristen pol’s picture

Assigned: kristen pol » Unassigned
Status: Needs review » Needs work

The image component is part of the base theme. Also note that baseline yamls/mds have been added so take a look at what is there and see if you find anything that needs updating.

kristen pol’s picture

Status: Needs work » Fixed

I've compared against the baseline and it looks good (note that we've removed required props for now).

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.