Problem/Motivation
This issue is for imalabya to test the SDC conversion script and the guide using:
- demo_design_system/components/01-atoms/image
Steps to reproduce
Proposed resolution
Go through the conversion guide and try to convert the component using the script and report any feedback.
Remaining tasks
- Review guide
- Follow guide to use the script
- Convert
demo_design_system/components/01-atoms/image - Report feedback here
User interface changes
API changes
Data model changes
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | Screenshot 2024-08-14 at 11.15.01 PM.png | 123.29 KB | imalabya |
Issue fork demo_design_system-3468117
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3468117-test-sdc-conversion
changes, plain diff MR !14
Comments
Comment #2
imalabyaComment #4
imalabya@Kristen Pol Below are the findings
- Reviewed the SDDS SDC conversion guide

- Used the conversion script to generate the yml file and README.md
- The image.component.yml & README.md file were generated inside
demo_design_system/components/01-atoms/image- Copied the
demo_design_system/components/01-atoms/imagetodemo_design_system/starshot_demo/components/01-atoms/image- Verified the SDC component in SDC Registry
Comment #5
imalabyaComment #6
kristen polAssigning to myself
Comment #7
kristen polThe image component is part of the base theme. Also note that baseline yamls/mds have been added so take a look at what is there and see if you find anything that needs updating.
Comment #8
kristen polI've compared against the baseline and it looks good (note that we've removed required props for now).