Problem/Motivation

Values in decimal fields are not saved anymore. Existing values are getting lost after saving the form.

Steps to reproduce

Saving encrypted decimal field in drupal ^10.2

Data model changes

looks like the data type of the field has (silently) changed to "decimal". It was "string" before.

Proposed resolution

Checking on "decimal" in `getUnencryptedPlaceholderValue()`

Issue fork field_encrypt-3465540

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

  • 3465540-drupal-10.2 Comparechanges, plain diff MR !47
    • 1 hidden branch
  • 3.0.x Comparecompare
About issue forks

Comments

pp.panatom created an issue. See original summary.

pp.panatom opened merge request !47

pp.panatom changed the visibility of the branch 3.0.x to hidden.

pp.panatom’s picture

pp.panatom commented
Status: Active » Needs review

added patch/merge request

ptmkenny’s picture

ptmkenny commented
Status: Needs review » Needs work
ptmkenny’s picture

ptmkenny commented
Related issues: +#3074420: Encrypted decimal fields do not respect zero-trailing decimal values
ptmkenny’s picture

ptmkenny commented
Status: Needs work » Closed (outdated)

Actually this was already fixed in the 3.2.x branch, so I'm closing this.

pp.panatom’s picture

pp.panatom commented

Looks like the fix did not make it into 3.2.0?

I could not find a change record for this in core. But it used to work before 10.2.
For backwards compatibility, the code for handling the "string-decimal" is still in there. So decimals with string data type are still handled like before.

ptmkenny’s picture

ptmkenny commented

3.2.0 has some trouble handling decimal values still; please try the MR in #3488771: Encrypted decimal field value not saved on drupal version 10.2.x+ and see if that fixes your issue.