[meeting] Migrate Meeting 2024-08-29 1400Z [#3465233]

Core migration issues

Next video meeting 2024-10-10

Hello all, it’s time for the biweekly migration subsystem meeting. The meeting will take place in slack in various threads. This meeting:
➤ Is for core migrate maintainers and developers and anybody else in the community with an interest in migrations
➤ Usually happens every second Thursday and alternates between 1400 and 2100 UTC.
➤ Is done on the #migration channel in Drupal Slack (see www.drupal.org/slack for information).
➤ Happens in threads, which you can follow to be notified of new replies even if you don’t comment in the thread. You may also join the meeting later and participate asynchronously!
➤ Has a public agenda anyone can add to. #3456078: [meeting] Migrate Meeting 2024-07-18 2100Z)See the parent issue for an idea of the typical agenda.
➤Transcript will be exported and posted to the agenda issue. For anonymous comments, start with a 👤 emoji. To take a comment or thread off the record, start with a 🚫 emoji.

0️⃣ Who is here today?

benjifisher	Hi!
mikelutz (he/him)	(insert local time of day), all!
alison	Hiya!
dinarcon	Hello, long time no chat :wave:
smustgrave	Hello
Dan Davis	Hey there
quietone	Hi!

1️⃣ What should we talk about today? Suggest topics here and I will add threads. I will also check for comments on the issue for today's meeting.

benjifisher	Two new process plugins NR.
benjifisher	Implement Entity::fields() for migration destinations
benjifisher	MigrateNoMigrateDrupalTest fails with missing classes in certain situations
benjifisher	Drupal\migrate\Plugin\Migration should provide a way to add dependencies
dinarcon	#3463800: Allow batch_size to work with joinable map tables and highwater Allow batch_size to work with joinable map tables and highwater
dinarcon	Would Migrate Plus/Tools maintainers be open to move Shared configuration for migrations from `migrate_tools` to `migrate_plus`?

2️⃣ Action items. To be added later.

smustgrave	There are 2 items in review that would be more comfortable with other eyes #3466289: MigrateNoMigrateDrupalTest fails with missing classes in certain situations (@benjifisher you worked on this one) #3466289: MigrateNoMigrateDrupalTest fails with missing classes in certain situations
smustgrave	Was I suppose to add these to the meeting?
benjifisher	I think you should let the person running the meeting handle this thread.
smustgrave	Just didn’t see one, didn’t know of the bot was suppose to pick it up
benjifisher	Maybe I do not understand your question. As far as this thread is concerned, I think that Action items. To be added later.is reasonably clear. We normally assign action items (if any) after the meeting.
smustgrave	alright cool
benjifisher	The two issues you added in this thread are in Threads 🔟 and 9️⃣. I added those threads before you mentioned them here.
benjifisher	Perhaps you just opened the wrong thread: :two: instead of :one:.
smustgrave	Rock on. Yup think you’re right there
smustgrave	Thanks!

3️⃣ Statistics

Migrate Initiative Meeting	346 open, 0 Fixed, 1 RTBC, 3 NR
Migrate Initiative Meeting	Google sheet for recording stats: https://docs.google.com/spreadsheets/d/1o0Rjlc1vnnLP5bM5P-SMMyGzqn7258hi...

4️⃣ Comment in this thread if you are looking for ways to contribute. Give us some idea of what you would like to do: documentation, code review, testing, project management, ...

Dan Davis

I am open to doing some documentation, code review or testing.

5️⃣ Previous minutes.

Migrate Initiative Meeting	#3463004: [meeting] Migrate Meeting 2024-08-01 1400Z (edited)
benjifisher	We need to add a transcript.
Dan Davis	I can work on this
Dan Davis	@mikelutz (he/him) for some reason I am seeing an error when trying to copy some threads from the Aug 1st meeting. I added an issue on the github repo for drupal-meeting-parser: `https://github.com/mdlutz24/drupal-meeting-parser/issues/24`
Dan Davis	I added a little patch to the chrome extension’s JS code. I will try to add it to the github issue later today.

6️⃣ Announcements

7️⃣ NR: Two new process plugins

Migrate Initiative Meeting	#3440904: Process plugin: build an array from source, destination, pipeline (edited) #3440904: Process plugin: build an array from source, destination, pipeline
Migrate Initiative Meeting	(Original Request) https://drupal.slack.com/archives/C226VLXBP/p1724940183181249?thread_ts=... (edited)
benjifisher	I wrote both of these plugins, so I need someone else to review them.
benjifisher	@alison: I made some changes to the snippet plugin since your comment #3123534-23: Process plugin: snippet to re-use YAML config. Can you make sure that the new version still works?
benjifisher	Now that the issue is NR, it would help to have another round of manual testing (the "T" in RTBC).

8️⃣ Implement Entity::fields() for migration destinations

Migrate Initiative Meeting	https://www.drupal.org/project/drupal/issues/2630732 (edited)
Migrate Initiative Meeting	(Original Request) https://drupal.slack.com/archives/C226VLXBP/p1724940421644719?thread_ts=... (edited)
benjifisher	I need to review the latest changes.
quietone	I was on my way to look and migrate:set issue but got sidetracked with this one! (edited)

9️⃣ MigrateNoMigrateDrupalTest fails with missing classes in certain situations

Migrate Initiative Meeting	https://www.drupal.org/project/drupal/issues/3466289 (edited)
Migrate Initiative Meeting	(Original Request) https://drupal.slack.com/archives/C226VLXBP/p1724940528575319?thread_ts=... (edited)
benjifisher	This is a recent issue filed by @catch, who also provided a simple MR (1-line change).
benjifisher	The issue is marked NR, but the tests are failing. Even if it is not an easy fix, anyone could help move the issue along by looking at the test failure and adding a comment to the issue. That will save the next person some effort.
benjifisher	The failure was a Nightwatch test. I triggered a re-test.
benjifisher	I thought I triggered a re-test. Why is this so hard?
catch	Nightwatch fails randomly a lot, should be safe to ignore for this one since it's not touching js.

🔟 Drupal\migrate\Plugin\Migration should provide a way to add dependencies

Migrate Initiative Meeting	https://www.drupal.org/project/drupal/issues/3464320 (edited)
Migrate Initiative Meeting	(Original Request) https://drupal.slack.com/archives/C226VLXBP/p1724940541819119?thread_ts=... (edited)
benjifisher	This is a piece of the long-stalled[#2796755]. It is a manageable chunk (+29/-4 not counting test changes).
benjifisher	@mikelutz (he/him), @quietone, are either of you available to review?
quietone	This is finally near the top of my list!

1️⃣1️⃣ Allow batch_size to work with joinable map tables and highwater

Migrate Initiative Meeting	https://www.drupal.org/project/drupal/issues/3463800
Migrate Initiative Meeting	(Original Request) https://drupal.slack.com/archives/C226VLXBP/p1724941065655039?thread_ts=... (edited)
benjifisher	This is marked NW, and it is assigned to @mikelutz (he/him).
dinarcon	This issue was created as part of this thoughtful conversation on optimizations for the drupal.org migration https://drupal.slack.com/archives/C226VLXBP/p1719916498819069
mikelutz (he/him)	I think your comments are correct in that issue, I hadn't fully tested it, and haven't gotten back to make adjustments.

1️⃣2️⃣ Shared configuration

Migrate Initiative Meeting	Does this belong in `migrate_tools` (where it is now) or `migrate_plus`?
Migrate Initiative Meeting	(Original Request) https://drupal.slack.com/archives/C226VLXBP/p1724941107901669?thread_ts=... (edited)
dinarcon	`migrate_plus` already offered migration groups to share configuration. The new Shared configuration seems like the evolution of migration groups and it seems appropriate for both systems to co-exists in the same module. (edited)
dinarcon	Most of `migrate_tools` functionality revolves about being a migration runner, either from the command line or from the UI. `migrate_plus` has historically extended the migration system with configuration entities, migration groups, extra migration plugins, events, etc.
dinarcon	If someone feels comfortable using the migration runner included in Drush core and wanted to use the new shared configuration system, they would have to add a second runner to get access to the functionality. While Migrate Tools and Drush core offer almost the same interface, there are a good amount of differences. #3213947: Drush core migrate commands integration refactor (edited)
dinarcon	pinging @heddn as a maintainer of both modules :see_no_evil:
heddn	interesting question. if someone wanted to open up an issue to port it over, we could probably do it
dinarcon	Issue created #3471311: Move shared configuration functionality to Migrate Plus module (edited)