Core migration issues

Next video meeting 2024-10-10

Hello all, it’s time for the biweekly migration subsystem meeting. The meeting will take place in slack in various threads. This meeting:
➤ Is for core migrate maintainers and developers and anybody else in the community with an interest in migrations
➤ Usually happens every second Thursday and alternates between 1400 and 2100 UTC.
➤ Is done on the #migration channel in Drupal Slack (see www.drupal.org/slack for information).
➤ Happens in threads, which you can follow to be notified of new replies even if you don’t comment in the thread. You may also join the meeting later and participate asynchronously!
➤ Has a public agenda anyone can add to. #3456078: [meeting] Migrate Meeting 2024-07-18 2100Z)See the parent issue for an idea of the typical agenda.
Transcript will be exported and posted to the agenda issue. For anonymous comments, start with a 👤 emoji. To take a comment or thread off the record, start with a 🚫 emoji.

0️⃣ Who is here today?

benjifisher Hello. Happy August, and happy "Drupal 11.0.0" week!
mikelutz (he/him) Hello all
alison Hi hi!
alison these go to eleven (819 kB)https://media4.giphy.com/media/aqSl7Dw5HTojK/giphy.gif?cid=6104955ej42t6... using /giphy | GIF by Maudit

1️⃣ What should we talk about today? Suggest topics here and I will add threads. I will also check for comments on the issue for today's meeting.

benjifisher Deprecating migrate_drupal
benjifisher Deprecate Migration::set() and related tasks
benjifisher New process plugin: snippet
benjifisher New process plugin: array_template

2️⃣ Action items. To be added later.

benjifisher #3123534: Process plugin: snippet to re-use YAML config: Rewrite issue summary, add tests. @benjifisher

3️⃣ Statistics

Migrate Initiative Meeting Fixed: 2 (not counting meetings); RTBC: 1; NR: 1 (Major)
Migrate Initiative Meeting Google sheet for recording stats: https://docs.google.com/spreadsheets/d/1o0Rjlc1vnnLP5bM5P-SMMyGzqn7258hi...

4️⃣ Comment in this thread if you are looking for ways to contribute. Give us some idea of what you would like to do: documentation, code review, testing, project management, ...

5️⃣ Previous minutes.

Migrate Initiative Meeting #3456078: [meeting] Migrate Meeting 2024-07-18 2100Z (edited)
benjifisher Already Fixed.

6️⃣ Announcements

7️⃣ Tasks to deprecate Migrate Drupal

Migrate Initiative Meeting #3315257: [meta] Tasks to deprecate Migrate Drupal (edited)
benjifisher The Plan issue is now Fixed: #3371229: [Policy] Migrate Drupal and Migrate Drupal UI after Drupal 7 EOL
benjifisher @quietone recently added #3463321: Deprecate Migrate Drupal UI, and I just marked the issues are Related.
benjifisher I think that deprecating migrate_drupal_ui will not be very complicated. Should we start there?
benjifisher The first item under "Remaining tasks" for migrate_drupal (#3315257) is

Move integrations implemented by other modules to the extension.

Are we still planning to do that?

benjifisher We are planning to move some things from migrate_drupal to migrate. At least the content_entity source plugin, Drupal\migrate_drupal\Plugin\migrate\source\ContentEntity.
benjifisher But the line I quoted seems to be saying that we should move the d7_node source plugin, Drupal\node\Plugin\migrate\source\d7\Node, to the migrate_drupal module. That was the plan at one point, and it would make the final removal easier, since it would all be in one module. But I do not think it is the current plan.
benjifisher @quietone closed the two child issues #3332224: Move migratefield plugins to migrate drupal and #3332998: Move migration code from content_translation to migrate_drupal as "won't fix". I think that is because we decided it would be too much work to move everything to migrate_drupal before removing it.
quietone The issue summary is the standard template for removing modules and moving them to core. I removed the obviously no longer needed steps but left anything that might possibly be needed.
quietone I can't think of any integrations.
quietone In about 2 weeks I was hoping to start working on these issues.

8️⃣ Deprecate Migration::set()

Migrate Initiative Meeting #2796755: [PP-1] Deprecate Migration::set() (edited)
benjifisher This issue has been hanging around for a long time.
benjifisher A few days ago, I opened yet another child issue: #3464320: Drupal\migrate\Plugin\Migration should provide a way to add dependencies.
benjifisher This bit of unfinished business caused serious problems: an infinite loop in the paragraphs module. Berdir had to resort to an ugly hack (their description, not mine) in order to avoid the recursion.
benjifisher @quietone, @alexpott: the three of us were working on the parent issue. Can you take a look at ^?
benjifisher I think that Yet Another Child Issue is not a bad thing in this case. The issue to deprecate Migration::set() had a big, ugly patch, and breaking it up into smaller pieces is a Good Idea (TM) according to https://www.drupal.org/docs/develop/issues/issue-procedures-and-etiquett....

9️⃣ Create a "pipeline" process plugin to re-use YAML config

Migrate Initiative Meeting #3123534: Process plugin: snippet to re-use YAML config (edited)
benjifisher The issue is NW for two reasons:
  1. Issue summary update.
  2. Tests
benjifisher I have been cautious about changing the issue title and the summary, since there are several suggestions on how to implement it and I do not want to push my own idea too strongly.
benjifisher But I think we have consensus that the snippet plugin is a good solution to the problem. @danflanagan8 explicitly endorsed it in the most recent comment, and several people are using it in their custom migrations.
benjifisher I also asked, in some previous meeting, whether we still need it now that we have shared configuration in the migrate_tools module. I think the answer is yes: snippet is still useful.
benjifisher TL;DR: I should update the issue summary and provide a test.
alison Happy user of snippet here, following along -- thank you!

I looked at your updates, I'm not equipped to test tests, I'll keep an eye on the issue, though. (edited)

🔟 Process plugin: build an array from source, destination, pipeline

Migrate Initiative Meeting #3440904: Process plugin: build an array from source, destination, pipeline (edited)
benjifisher I find this plugin incredibly useful ... but I am biased, because I wrote it.
benjifisher The issue is NR. The issue summary and comments have several examples of how it can be used.
amaisano NR?
benjifisher Needs Review
joelpittet Had a quick look @benjifisher and it went way over my head in terms of use-case, probably because I have not needed callback or service yet. Just wanted you to know I had a look but ended up like :upside_down_face:
benjifisher Thanks for trying.
joelpittet A targeted review audience, aka poking the people in the issue comments, may yield better feedback
joelpittet As they might face the problem, assuming that’s why they are there
benjifisher FWIW, here is another example. Apply skip_on_empty to both subfields of a formatted-text field:
    field_body:
    - plugin: skip_on_empty
      method: process
      source: body/0/value
    - plugin: array_template
      template:
        value: 'pipeline:'
        format: hwp_full_html
joelpittet It’s tricky to see/grok that is happening by looking at that.
joelpittet gotta reboot, --sync went rogue and ate up all my disk space.

1️⃣1️⃣ Wrap-Up

Migrate Initiative Meeting Thanks for coming all! See you in 2 weeks

Comments

benjifisher created an issue. See original summary.

ddavisboxleitner’s picture

Issue summary: View changes

benjifisher’s picture

Issue summary: View changes
Status: Active » Needs review

@ddavisboxleitner:

Thanks for adding the transcript. Next time, please set the issue status to NR when you do that.

Unfortunately, the meeting parser seems to be giving incomplete results. I am having trouble with it, too. I added a bunch of missing comments and some formatting.

benjifisher’s picture

Issue summary: View changes
benjifisher’s picture

Issue summary: View changes
smustgrave’s picture

Status: Needs review » Fixed

@Benjifisher there was a bug recently https://github.com/mdlutz24/drupal-meeting-parser/issues/23#issuecomment... but seems to have been resolved. I'm not super familiar with custom plugins but was told have to update the git branch of the extension locally and reload in chrome.

That fixed it for me at least if that's the error being seen

For this meeting though went into #migration for 8-01-2024 and verified threads were captured.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.