The task is to fix all the cspell, upgrade status and phpstan issues that can be found in the recent pipelines - https://git.drupalcode.org/project/linkchecker/-/pipelines

Issue fork linkchecker-3465025

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

quadrexdev created an issue. See original summary.

quadrexdev opened merge request !76

quadrexdev’s picture

quadrexdev
Location Lutsk
commented
Title: Fix cspell issues » Fix cspell, phpstan issues
Issue summary: View changes
quadrexdev’s picture

quadrexdev
Location Lutsk
commented
Title: Fix cspell, phpstan issues » Fix cspell, upgrade status and phpstan issues
Issue summary: View changes

1) We'll allow failing for such jobs as phpstan, cspell, and upgrade status so it won't prevent us from further dev release updates.

@todo - revert it once this issue is fixed.

2) Still, some tests failed within the PHPUnit job so it should be fixed too.

quadrexdev’s picture

quadrexdev
Location Lutsk
commented

Alright, the tests are fixed. Remaining stuff:

a) cspell issues
b) eslint issues
c) phpstan issues
d) upgrade status issues
e) revert allow_failure for the cspell, eslint, phpstan, upgrade status so it should be equal to false

quadrexdev opened merge request !77

quadrexdev opened merge request !78

quadrexdev closed merge request !78

quadrexdev credited eiriksm.

quadrexdev’s picture

quadrexdev
Location Lutsk
commented
Status: Active » Fixed

Alright, everything seems to be resolved.

Thanks @eiriksm for reviewing the merge request!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

I suggest tagging 2.0.1 with just the fixes for this issue. That would allow people using 2.0.0 to run the same code but without the errors about creation of dynamic property.