Problem/Motivation

There isn't a way to hide the side nav on the event content type.

Steps to reproduce

  1. Create a new event
  2. Look for the checkbox to hide the side nav. In the Page content type this is in the 'Appearance' section

Observed behaviour

There is no checkbox present

Expected behaviour

There should be a checkbox present, ideally in the same place as the Page content type, inside the Appearance section.
Also, consider if it should be checked by default to hide the Event. This is the opposite behaviour of the Page, but in my experience, Event pages usually don't have a side nav.

Proposed resolution

CommentFileSizeAuthor
#5 Hide sidebar option visible.png351.43 KBmanishvijay02
#5 Hide Sidebar Option not enable.png130.9 KBmanishvijay02
#5 Hide Sidebar Option Enable.png369.13 KBmanishvijay02
#5 Hide Sidebar Enable After.png99.05 KBmanishvijay02
#4 civictheme_after_event_node2.png55.92 KBtirupati_singh
#4 civictheme_after_event_node-edit2.png124.75 KBtirupati_singh
#4 civictheme_after_event_node.png107.25 KBtirupati_singh
#4 civictheme_after_event_node-edit.png123.28 KBtirupati_singh
#4 civictheme_before_event.png65.49 KBtirupati_singh

Issue fork civictheme-3464836

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

fionamorrison23 created an issue. See original summary.

tirupati_singh’s picture

tirupati_singh commented
Assigned: Unassigned » tirupati_singh

tirupati_singh opened merge request !11

tirupati_singh’s picture

tirupati_singh commented
Assigned: tirupati_singh » Unassigned
Status: Active » Needs review
StatusFileSize
new civictheme_before_event.png65.49 KB
new civictheme_after_event_node-edit.png123.28 KB
new civictheme_after_event_node.png107.25 KB
new civictheme_after_event_node-edit2.png124.75 KB
new civictheme_after_event_node2.png55.92 KB

Hi @fionamorrison23, I've added the new field Hide sidebar to the Event content type. Now, the sidebar can be shown/hidden by enabling the Hide sidebar field. I've attached the relevant screenshots for your reference. Please review the changes.

Thanks!

manishvijay02’s picture

manishvijay02 commented
StatusFileSize
new Hide Sidebar Enable After.png99.05 KB
new Hide Sidebar Option Enable.png369.13 KB
new Hide Sidebar Option not enable.png130.9 KB
new Hide sidebar option visible.png351.43 KB

Hii,
I have tested the MR and the MR is working fine as per expectations. When the hide sidebar option is enable the sidebar is hiding and the content is taking full width.
Moving to RTBC+.

manishvijay02’s picture

manishvijay02 commented
Status: Needs review » Reviewed & tested by the community
fionamorrison23’s picture

fionamorrison23 commented
Assigned: Unassigned » richardgaunt

Hi @richardgaunt can you please check this one? If this work is done and ready to go in the right repo, let's release it.

fionamorrison23’s picture

fionamorrison23 commented
Version: 1.8.1 » 1.x-dev
fionamorrison23’s picture

fionamorrison23 commented
Status: Reviewed & tested by the community » Active
fionamorrison23’s picture

fionamorrison23 commented
Status: Active » Needs review
Issue tags: +civictheme-release-1.13
fionamorrison23’s picture

fionamorrison23 commented
Issue summary: View changes
richardgaunt’s picture

richardgaunt commented
Assigned: richardgaunt » joshua1234511

@joshua12345 can you port to the monorepo.

joshua1234511’s picture

joshua1234511
Primary language English
Location Goa
commented
Assigned: joshua1234511 » richardgaunt

Updated code
Added appropriate hook update.
https://github.com/civictheme/monorepo-drupal/pull/1464

richardgaunt’s picture

richardgaunt commented
Assigned: richardgaunt » danielgry

  • cd94e83a committed on 1.x 
    Issue #3464836 by richardgaunt, tirupati_singh, manishvijay02,...
richardgaunt’s picture

richardgaunt commented
Status: Needs review » Reviewed & tested by the community
richardgaunt’s picture

richardgaunt commented
Version: 1.x-dev » 1.13.0
Assigned: danielgry » Unassigned
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.