Problem/Motivation

The config schema for EntityView block which defines view_mode configuration is missing.

The schema violation happens only since D11.1 and #3379725: Make Block config entities fully validatable which removed the view_mode key in core's block_settings schema.

Proposed resolution

Add missing config schema for this block, add test.

Remaining tasks

None

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#5 3464574-5.diff2.43 KBherved

Issue fork ctools-3464574

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

andypost created an issue. See original summary.

tstermitz’s picture

tstermitz
Location Colorado
commented

When using ctools entity_view (content) to place a view_mode in blocks, I get the following error warning message. The site works, but it always shows the warning:

Schema errors for block.block.mytheme_entityviewcontent_2 with the following errors: block.block.mytheme_entityviewcontent_2:settings.view_mode missing schema. These errors mean there is configuration that does not comply with its schema. This is not a fatal error, but it is recommended to fix these issues.

I'm using Drupal CMS v1.2 with a Radix 6.02 subtheme. Drupal 11.2

herved made their first commit to this issue’s fork.

herved opened merge request !81

herved’s picture

herved commented
Title: Missing config schema for view_mode stored in block » Missing config schema for entity_view block (D11+)
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new 3464574-5.diff2.43 KB

Updated IS, added MR and test coverage (the test fails correctly on D11 without the fix).
Adding also static patch for composer.

ericgsmith’s picture

ericgsmith commented
Status: Needs review » Reviewed & tested by the community

https://git.drupalcode.org/issue/ctools-3464574/-/jobs/7530512#L110 shows test only change - looks good to me and resolves the config errors - good work.

tim-diels’s picture

tim-diels
He/Him
Primary language Dutch
Location Belgium 🇧🇪
commented

Configuration inspector gave same warning. The change looks good to me also. +1

  • joelpittet committed 4d403419 on 4.1.x authored by herved 
    feat: #3464574 Missing config schema for entity_view block (D11+)

By:...
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented

Thank you all, I have committed this to the dev branch.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.