Problem/Motivation

#3417136: Remove adding an extension via a URL has been completed in Core. This removed the Add Module page. It has been backported to Drupal 11.0 and 10.4, so will soon be removed from the active versions of Drupal.

The removal is causing failure of the DisableAddNewModuleTest test.

This feature was added to Project Browser as it was hoped to be moving to core before

Steps to reproduce

See test failure pipeline.

Proposed resolution

Basically, undo the changes made in #3361123: Add "Disable Add new module page" option to settings page.

When the change was made, it was expected that Project Browser would move into core before the Add Module page could be removed, but it has taken longer than expected. Getting this change into D11.0 and 10.4 is a great achievement.

Issue fork project_browser-3463833

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

lostcarpark created an issue. See original summary.

lostcarpark opened merge request !552

lostcarpark’s picture

lostcarpark commented
Status: Active » Needs review

Made the change to remove the hiding of Add New Module page.

All tests now passing.

Setting to needs review.

lostcarpark’s picture

lostcarpark commented
Assigned: lostcarpark » Unassigned
fjgarlin’s picture

fjgarlin commented
Status: Needs review » Reviewed & tested by the community

Reviewed the code and the clean up looks good.

Tests are also fully green, for all versions of Drupal that are tested.

Tested via DrupalPod and it all looks good. The option is no longer there. I even tried forcing the setting on the config file and running the updb command and it went away.

RTBC.

chrisfromredfin made their first commit to this issue’s fork.

chrisfromredfin’s picture

chrisfromredfin
he/him/his
Primary language English
Location Portland, Maine
commented
Status: Reviewed & tested by the community » Fixed

Wonderful, and good riddance ;)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.