Implement the updated insert menu. On the updated version, the layers panel is kept on the left. Insert button is in the header, and opens on top of layers.
| Comment | File | Size | Author |
|---|---|---|---|
| #20 | Screenshot 2024-08-14 at 5.12.49 PM.png | 326.64 KB | hooroomoo |
| #20 | Screenshot 2024-08-14 at 5.13.01 PM.png | 382.01 KB | hooroomoo |
| #16 | Screenshot 2024-08-13 at 9.07.32 PM.png | 272.14 KB | hooroomoo |
| Screenshot 2024-07-18 at 5.54.58 PM.png | 237.54 KB | lauriii | |
| Screenshot 2024-07-18 at 5.55.04 PM.png | 240.57 KB | lauriii |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes, plain diff MR !147changes, plain diff MR !120
Comments
Comment #2
lauriiiComment #3
wim leersThis blocks #3462314, see #3462314-2: Improve primary menu bar - remove need for "overlayForHover" .
Also, #3461435: End-to-end test that tests both the client (UI) and server just landed, so I think it's time we start requiring basic test coverage for each new piece in the UI?
Comment #4
jessebaker commentedAssigning to @hooroomoo as they have been working on the left hand menu so far.
Sorry hooroomoo, it looks like there are some iterations/updates required to the menu work you did now that the designs have progressed further.
Comment #5
wim leers(To elaborate on #4: @hooroomoo landed that in #3456084: Add initial implementation of primary menu.)
Comment #8
wim leersComment #9
wim leersUnassigning @hooroomoo, because AFAICT they're not actively working on this?
Comment #10
hooroomooPicking this back up now that #3460952: Implement add button for top level item (section) is in
Removing blocker tag bc this issue will be removing the overlayForHover since tooltip is no longer part of the design.
Comment #13
wim leersCould you link to the source for that? 🙏
Comment #14
hooroomoo#13 I should make a correction
"will be removing the overlayForHover since
tooltipthe first level menu in the sidebar with the icons is no longer part of the design as seen in the screenshots in the IS and the Figma."The first level menu in the left sidebar has the overlayForHover attribute which will be removed in this issue.
Comment #16
hooroomooThe tests still need to be fixed but the implementation can be reviewed
Comment #17
hooroomooComment #18
hooroomooRemoving the needs tests tag. Tests for the Layers (tree) should be done as part of #3458503: Improve the page hierarchy display.
The MR has a solid foundation for #3458503: Improve the page hierarchy display but still needs styling/dragging tweaking when with nested components.
Comment #19
hooroomooComment #20
hooroomooComment #22
hooroomooYippee