Overview

In the primary menu bar the Radix MenuBar primative component is used. There is a requirement to show tooltips on hover of the Menubar.Trigger. The current clever solution is to overlay an absolutely positioned invisible element over the top to trigger the tooltip and for that to handle pointerDown events to trigger the menu.

BUT this causes issues with writing e2e tests as the invisible overlay is blocking being able to click the actual item.

Proposed resolution

I think use of the asChild={true} prop on the Menubar.Trigger component would allow the TooltipComponent to live inside Menubar.Trigger rather than having to overlay on top of it.

User interface changes

UI should look the way it does now from a user perspective but with a cleaner underlying DOM structure.

Comments

jessebaker created an issue. See original summary.

lauriii’s picture

Status: Active » Closed (outdated)
wim leers’s picture

Status: Closed (outdated) » Postponed (maintainer needs more info)
Related issues: +#3462314: Improve primary menu bar - remove need for "overlayForHover" , +#3462413: Implement the updated insert menu and layers panel

Surfaced by @jessebaker's review of #3462314: Improve primary menu bar - remove need for "overlayForHover" .

Linking @lauriii's #2. I doubt @lauriii intended to close this?

lauriii’s picture

Status: Postponed (maintainer needs more info) » Postponed

Ah good catch @Wim Leers. I meant to postpone this.

wim leers’s picture

Title: Improve primary menu bar - remove need for "overlayForHover" » [PP-1] Improve primary menu bar - remove need for "overlayForHover"
lauriii’s picture

Status: Postponed » Closed (outdated)

Confirmed with @hooroomoo that this is no longer needed after #3462413: Implement the updated insert menu and layers panel.

hooroomoo’s picture

Assigned: hooroomoo » Unassigned
wim leers’s picture

Title: [PP-1] Improve primary menu bar - remove need for "overlayForHover" » Improve primary menu bar - remove need for "overlayForHover"