Problem/Motivation
As a content admin,
I want to easily apply styles to my content.
so that I can make an engaging page that follow only the approved styles per the guide.
Proposed resolution
- #3462274: Add a Root component as a Base, Contains root CSS3 Bootstrap variables to Varbase Components
- Add a new component called "root" as a
Subatomic particleBase: Consisting of the color palette, typography, shadows, and spacing. which will contain a list of CSS3 variables. - Include the new root component to
vartheme_bs5and load the component instead to be part of the"bootstrap.base.scss"file. - Add
varbase_components/root: vartheme_bs5/rootinlibraries-overridein thevartheme_bs5.info.ymlfile
This will be removed from the "bootstrap.base.scss" file and moved to be a component.
Change on Cloned Generated Theme themes
( new and old custom cloned themes)
- Add
ckeditor5.bootstrap.base.cssfile tockeditor5-stylesheetsin thevartheme_bs5.info.ymlfile. with .ck-content wrapper class
ckeditor5-stylesheets: - css/base/ckeditor5.bootstrap.base.csswith
@import "../defaults"; // Global defaults. // CKEditor 5 integration with Bootstrap 5 styling. // ----------------------------------------------------------------------------- .ck-content { @import "../../node_modules/bootstrap/scss/reboot"; @import "../../node_modules/bootstrap/scss/type"; @import "../../node_modules/bootstrap/scss/images"; @import "../../node_modules/bootstrap/scss/tables"; @import "../../node_modules/bootstrap/scss/buttons"; @import "../../node_modules/bootstrap/scss/badge"; @import "../../node_modules/bootstrap/scss/list-group"; }
Remaining tasks
- ✅ File an issue about this project
- ✅ Addition/Change/Update/Fix to this project
- ✅ Testing to ensure no regression
- ➖ Automated unit/functional testing coverage
- ➖ Developer Documentation support on feature change/addition
- ➖ User Guide Documentation support on feature change/addition
- ➖ UX/UI designer responsibilities
- ➖ Accessibility and Readability
- ✅ Code review from 1 Varbase core team member
- ✅ Full testing and approval
- ✅ Credit contributors
- ✅ Review with the product owner
- ✅ Update Release Notes and Update Helper on new feature change/addition
- ✅ Release varbase-10.0.1, vartheme_bs5-3.0.1
Varbase update type
- ✅ No Update
- ➖ Optional Update
- ➖ Forced Update
- ➖ Forced Update if Unchanged
User interface changes
- #3466509: Change the list of styles for heading with display, callout, alert and remove leftover BS3 and BS4 legacy classes and logic in favour of the new logic in Bootstrap 5
- #3462855: Add ckeditor5-styles library with dependencies from other used components to use it for ckeditor5 styles
API changes
- N/A
Data model changes
- N/A
Release notes snippet
Issue fork vartheme_bs5-3462276
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
n.ghunaim commentedComment #4
n.ghunaim commentedComment #5
n.ghunaim commentedComment #6
rajab natshahComment #7
rajab natshahComment #8
rajab natshahComment #9
rajab natshahComment #12
rajab natshahComment #13
rajab natshahComment #14
rajab natshahComment #15
rajab natshahComment #16
rajab natshahAdd
ckeditor5.bootstrap.base.cssfile tockeditor5-stylesheetsin thevartheme_bs5.info.ymlfile. ( with .ck-content wrapper class )with
Comment #17
rajab natshahComment #18
rajab natshahComment #21
rajab natshahComment #22
rajab natshahComment #24
rajab natshahComment #25
rajab natshahComment #26
rajab natshah✅ Released vartheme_bs5-3.0.1
Comment #27
rajab natshahComment #28
rajab natshah✅ Released varbase-10.0.1