Problem/Motivation

As a content admin,
I want to easily apply styles to my content.
so that I can make an engaging page that follow only the approved styles per the guide.

Proposed resolution

This will be removed from the "bootstrap.base.scss" file and moved to be a component.

#3467445: Fix theme source theme vartheme_bs5 is not a valid starter kit when Create new Vartheme BS5 Cloned Generated Theme

Change on Cloned Generated Theme themes
( new and old custom cloned themes)

  • Add ckeditor5.bootstrap.base.css file to ckeditor5-stylesheets in the vartheme_bs5.info.yml file. with .ck-content wrapper class

    ckeditor5-stylesheets:
      - css/base/ckeditor5.bootstrap.base.css
    

    with

    @import "../defaults";   // Global defaults.
    
    // CKEditor 5 integration with Bootstrap 5 styling.
    // -----------------------------------------------------------------------------
    
    .ck-content {
      @import "../../node_modules/bootstrap/scss/reboot";
      @import "../../node_modules/bootstrap/scss/type";
      @import "../../node_modules/bootstrap/scss/images";
      @import "../../node_modules/bootstrap/scss/tables";
      @import "../../node_modules/bootstrap/scss/buttons";
      @import "../../node_modules/bootstrap/scss/badge";
      @import "../../node_modules/bootstrap/scss/list-group";
    }
    
    

Remaining tasks

  • ✅ File an issue about this project
  • ✅ Addition/Change/Update/Fix to this project
  • ✅ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support on feature change/addition
  • ➖ User Guide Documentation support on feature change/addition
  • ➖ UX/UI designer responsibilities
  • ➖ Accessibility and Readability
  • ✅ Code review from 1 Varbase core team member
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Update Release Notes and Update Helper on new feature change/addition
  • ✅ Release varbase-10.0.1, vartheme_bs5-3.0.1

Varbase update type

  • ✅ No Update
  • ➖ Optional Update
  • ➖ Forced Update
  • ➖ Forced Update if Unchanged

User interface changes

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • Issue #3462276 by n.ghunaim: Added a Root component as a Base, Contains root CSS3 Bootstrap variables to Vartheme BS5
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

n.ghunaim created an issue. See original summary.

n.ghunaim’s picture

Issue summary: View changes

n.ghunaim’s picture

Status: Active » Needs review
rajab natshah’s picture

Version: 3.0.0 » 3.0.x-dev
rajab natshah’s picture

Title: Includes the root component to vartheme_bs5 » Add root particle component to Vartheme BS5
Issue summary: View changes
rajab natshah’s picture

Title: Add root particle component to Vartheme BS5 » Add a Root component as a Base to Vartheme BS5
rajab natshah’s picture

Title: Add a Root component as a Base to Vartheme BS5 » Add a Root component as a Base, Contains root CSS3 Bootstrap variables to Vartheme BS5

  • rajab natshah committed 1677eb9a on 3.0.x
    Issue #3462276: Add varbase_components/root: vartheme_bs5/root in...
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes

Add ckeditor5.bootstrap.base.css file to ckeditor5-stylesheets in the vartheme_bs5.info.yml file. ( with .ck-content wrapper class )

ckeditor5-stylesheets:
  - css/base/ckeditor5.bootstrap.base.css

with

@import "../defaults";   // Global defaults.

// CKEditor 5 integration with Bootstrap 5 styling.
// -----------------------------------------------------------------------------

.ck-content {
  @import "../../node_modules/bootstrap/scss/reboot";
  @import "../../node_modules/bootstrap/scss/type";
  @import "../../node_modules/bootstrap/scss/images";
  @import "../../node_modules/bootstrap/scss/tables";
  @import "../../node_modules/bootstrap/scss/buttons";
  @import "../../node_modules/bootstrap/scss/badge";
  @import "../../node_modules/bootstrap/scss/list-group";
}

rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes

  • rajab natshah committed aa1a8ef8 on 3.0.x
    Issue #3462276: Add ckeditor5.bootstrap.base.css file to ckeditor5-...

  • rajab natshah committed cf8f5294 on 3.0.x
    Issue #3462276: Add ckeditor5.bootstrap.base.css file to ckeditor5-...
rajab natshah’s picture

Issue summary: View changes
Issue tags: +varbase-10.0.1, +vartheme_bs5-3.0.1

  • rajab natshah committed 5debada5 on 3.0.x
    Issue #3462276: Change to improve the wording of the Root component,...
rajab natshah’s picture

Status: Needs review » Fixed
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

✅ Released vartheme_bs5-3.0.1

rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes

✅ Released varbase-10.0.1

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.