Problem/Motivation
The following 2 classes are leftover
Well style was deprecated in BS4 - but we had a Legacy for this in Vartheme BS4 - ( Dropped out in Vartheme BS5 ) - this came late – as the switch to CKEditor 5 was late in Drupal 10.2 and 10.3
Card is supported BS4 and BS5, But it was as a replacement of the Panels in BS3 ( but deprecated/and dropped in BS4 ) - we had a legacy for this in Vartheme BS4 too .. Dropped in Vartheme BS5
It is better to follow the new logic, not to keep a grip on an old method
Proposed resolution
- Remove any use of
.wellclass in any Rich Editor text format. - Remove any use of
.cardclass in any Rich Editor text format. - Change the list of styles as provided by the product lead
h2.display-1|Display 1 (h2) h2.display-2|Display 2 (h2) h2.display-3|Display 3 (h2) h2.display-4|Display 4 (h2) h2.display-5|Display 5 (h2) h2.display-6|Display 6 (h2) h3.display-1|Display 1 (h3) h3.display-2|Display 2 (h3) h3.display-3|Display 3 (h3) h3.display-4|Display 4 (h3) h3.display-5|Display 5 (h3) h3.display-6|Display 6 (h3) h4.display-1|Display 1 (h4) h4.display-2|Display 2 (h4) h4.display-3|Display 3 (h4) h4.display-4|Display 4 (h4) h4.display-5|Display 5 (h4) h4.display-6|Display 6 (h4) h5.display-1|Display 1 (h5) h5.display-2|Display 2 (h5) h5.display-3|Display 3 (h5) h5.display-4|Display 4 (h5) h5.display-5|Display 5 (h5) h5.display-6|Display 6 (h5) h6.display-1|Display 1 (h6) h6.display-2|Display 2 (h6) h6.display-3|Display 3 (h6) h6.display-4|Display 4 (h6) h6.display-5|Display 5 (h6) h6.display-6|Display 6 (h6) p.bs-callout|Callout p.alert.alert-success|Alert success p.bs-callout.bs-callout-info|Callout Info p.alert.alert-info|Alert info p.bs-callout.bs-callout-warning|Callout warning p.alert.alert-warning|Alert warning p.bs-callout.bs-callout-danger|Callout danger p.alert.alert-danger|Alert danger - Hide
ck-disabledck-offBlock Styles when selecting an HTML tag - Have a hook update to change this config
Remaining tasks
- ✅ File an issue about this project
- ✅ Addition/Change/Update/Fix to this project
- ✅ Testing to ensure no regression
- ➖ Automated unit/functional testing coverage
- ➖ Developer Documentation support on feature change/addition
- ➖ User Guide Documentation support on feature change/addition
- ✅ UX/UI designer responsibilities
- ✅ Accessibility and Readability
- ✅ Code review from 1 Varbase core team member
- ✅ Full testing and approval
- ✅ Credit contributors
- ✅ Review with the product owner
- ✅ Update Release Notes and Update Helper on new feature change/addition
- ✅ Release varbase-10.0.1, varbase_editor-10.0.4
Varbase update type
- ➖ No Update
- ➖ Optional Update
- ➖ Forced Update
- ✅ Forced Update if Unchanged
User interface changes
API changes
- N/A
Data model changes
- N/A
Release notes snippet
Issue fork varbase_editor-3466509
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:





Comments
Comment #3
n.ghunaim commentedComment #5
rajab natshahComment #6
rajab natshahComment #8
rajab natshahComment #11
rajab natshahComment #13
rajab natshahComment #14
rajab natshahComment #15
rajab natshahComment #16
rajab natshahComment #17
rajab natshahComment #18
rajab natshahComment #19
rajab natshahComment #20
rajab natshah✅ Released vartheme_bs5-3.0.1
Comment #21
rajab natshahComment #22
rajab natshah✅ Released varbase_editor-10.0.4
Comment #23
rajab natshah✅ Released varbase-10.0.1