Problem/Motivation

Having no style and no component for the Bootstrap Callout style in CKEditor 5

Proposed resolution

  • Add a new component called Callout
  • Use the custom .bs-callout CSS class to stand for Bootstrap Callout and be isolated from .callout

Callout styles - Left to right (LTR)
Callout styles - Left to right (LTR)

Callout styles - Right to left (LTR)
Callout styles - Right to left (LTR)


Callout with styling options
Callout with styling options

Remaining tasks

  • ✅ File an issue about this project
  • ✅ Addition/Change/Update/Fix to this project
  • ✅ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ✅ Developer Documentation support on feature change/addition
  • ➖ User Guide Documentation support on feature change/addition
  • ➖ UX/UI designer responsibilities
  • ➖ Accessibility and Readability
  • ✅ Code review from 1 Varbase core team member
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Update Release Notes and Update Helper on new feature change/addition
  • ✅ Release varbase-10.0.1, varbase_components-2.0.4

Varbase update type

  • ✅ No Update
  • ➖ Optional Update
  • ➖ Forced Update
  • ➖ Forced Update if Unchanged

User interface changes

Storybook page for the Callout component
Storybook page for the Callout component

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • Issue #3461722 by n.ghunaim: Added a Callout component to function as a Bootstrap Callout element
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

n.ghunaim created an issue. See original summary.

n.ghunaim’s picture

Status: Active » Needs review
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Title: Add new component - bs-callout » Add bs-callout component
Version: 2.0.3 » 2.0.x-dev
rajab natshah’s picture

Status: Needs review » Needs work

Let us add a stories for the bs-callout component in Varbase Storybook

n.ghunaim’s picture

Status: Needs work » Needs review
rajab natshah’s picture

Title: Add bs-callout component » Add A Callout component
Issue summary: View changes
rajab natshah’s picture

Title: Add A Callout component » Add a Callout component to function as a Bootstrap Callout element
rajab natshah’s picture

Issue summary: View changes
Status: Needs review » Needs work
StatusFileSize
new41.38 KB

➖ UX/UI designer responsibilities

Better to check with the design team to
add Callout component to the public Varbase Design System

I see a Bootstrap 4 styling and logic not Bootstrap 5 styling

By the way the Callout is a custom example.. It is not ready out of the box in Bootstrap 5
https://getbootstrap.com/docs/5.3/customize/components/#creating-your-own

Bootstrap 5.3.3 suggest to have callout look like

Not as we had in Bootstrap 4
bs-callout

Some custom Design Systems are keeping the old BS4 in BS5 like
https://coreui.io/bootstrap/docs/components/callout/

For the history of this.
It was requested by Razem back in Vartheme BS4 to add the callout as a custom component to be used in CKEditor 4

Better to follow with the Bootstrap ~5.3 logic and methods.

n.ghunaim’s picture

Status: Needs work » Needs review
rajab natshah’s picture

Issue summary: View changes
StatusFileSize
new30.58 KB
new33.17 KB

rajab natshah’s picture

Issue summary: View changes
Issue tags: +varbase-10.0.1, +varbase_components-2.0.4

  • rajab natshah committed 7c5d5d6c on 2.0.x
    Issue #3461722: Improve the wording for the Callout component and set...

  • rajab natshah committed ab92d354 on 2.0.x
    Issue #3461722: Improve the wording for the Callout component and set...
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

rajab natshah’s picture

Status: Needs review » Fixed
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes

The public link for the Callout stories

rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes

✅ Released varbase-10.0.1

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.