Problem/Motivation

The status report shows a warning "TTL settings under a month are not recommended, the longer you set it, the better your site will perform!" if your TTL is lower than 32 days. There are 4 months with 30 days, 7 months with 31 days and one month with 28 or 29 days, but no months with 32 days. Since the definition of a month is fairly loose I think we should consider a TTL >= 28 days to be close enough to a month.

Steps to reproduce

Set TTL to 2419200 (28 days), or 2678400 (31 days). See status report.

Proposed resolution

Update requirements check to < 2419200.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork purge-3459162

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mstrelan created an issue. See original summary.

mstrelan opened merge request !45

mstrelan’s picture

mstrelan commented
Status: Active » Needs review
o&#039;briat’s picture

o'briat
Primary language French
Location Nantes
commented

This checks values (24h, one month, one year) seem very strange if not dangerous.

$this->config->get('cache.page.max_age') is the value that Drupal use as max-age in the cache-control header of the response send to the client.
This value will be used by reverse proxy such as Varnish but also by the client browser which could not be purged by Drupal.

Could someone explain these choices?
Do you rely on conditional request header (If-None-Match, ...) or do you rewrite this header in Varnish?

If there is no reasons, just delete entirely this check.

o&#039;briat’s picture

o'briat
Primary language French
Location Nantes
commented
Related issues: +#3459162: Loosen the requirements check for TTL below one month

See also "Cache Max Age warning text"