Update Drupal Core to ~10.3.0 and ~11.0.0 with support for recipes in Varbase Media version requirements [#3457305]

Problem/Motivation

Drupal 10.3.0 stable was released on: 20 Jun 2024 by: catch
https://www.drupal.org/project/drupal/releases/10.3.0

Thanks, to the Drupal Core release team

Drupal 11.0.0-rc1 about to be released

Coming Soon

Proposed resolution

Change core_version_requirement to ~10.3.0 || ~11.0.0 in the .info.yml file.
Change drupal/core to ~10.3.0 || ~11.0 in the composer.json file.
Switch to a Default Varbase Media recipe and drop the use of the Module Installer Factory class in favour of Drupal Recipes

Remaining tasks

✅ File an issue about this project
✅ Addition/Change/Update/Fix to this project
✅ Testing to ensure no regression
➖ Automated unit/functional testing coverage
➖ Developer Documentation support on feature change/addition
➖ User Guide Documentation support on feature change/addition
➖ UX/UI designer responsibilities
➖ Accessibility and Readability
✅ Code review from 1 Varbase core team member
✅ Full testing and approval
✅ Credit contributors
✅ Review with the product owner
✅ Update Release Notes and Update Helper on new feature change/addition
✅ Release varbase-10.0.0, varbase_media-10.0.2, varbase-9.1.4, varbase_media-9.1.11

Varbase update type

✅ No Update
➖ Optional Update
➖ Forced Update
➖ Forced Update if Unchanged

User interface changes

API changes

Data model changes

Release notes snippet

Issue #3457305: Update Drupal Core to ~10.3.0 and ~11.0.0 with support for recipes in Varbase Media version requirements

Comments

Comment #1

26 June 2024 at 12:29

Rajab Natshah created an issue. See original summary.

Comment #2

rajab natshah

he/him

commented 26 June 2024 at 12:35

 ./bin/drush upgrade_status:analyze varbase_media
 [notice] Processing /var/www/html/dev/varbase10x5/docroot/modules/contrib/varbase_media.

================================================================================
Varbase Media, --
Scanned on Wed, 06/26/2024 - 15:33

FILE:
modules/contrib/varbase_media/modules/entity_browser_generic_embed/entity_browse
r_generic_embed.module

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Fix later      142  Call to deprecated function file_validate(). Deprecated in  
                    drupal:10.2.0 and is removed from drupal:11.0.0. Use the    
                    'file.validator' service instead.                           
--------------------------------------------------------------------------------

FILE:
modules/contrib/varbase_media/modules/entity_browser_generic_embed/src/Form/Medi
aForm.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 13   Class Drupal\entity_browser_generic_embed\Form\MediaForm    
                    extends @internal class Drupal\media\MediaForm.             
--------------------------------------------------------------------------------
Check manually 49   #pre_render callback method                                 
                    'array{$this(Drupal\entity_browser_generic_embed\Form\MediaF
                    orm), 'renderPreview'}' at key '0' does not implement       
                    attribute \Drupal\Core\Security\Attribute\TrustedCallback.  
--------------------------------------------------------------------------------

FILE:
modules/contrib/varbase_media/modules/entity_browser_generic_embed/src/MediaHelp
er.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Ignore         151  Fetching deprecated class constant EXISTS_RENAME of class   
                    Drupal\Core\File\FileSystemInterface. Deprecated in         
                    drupal:10.3.0 and is removed from drupal:12.0.0. Use        
                    Drupal\Core\File\FileExists::Rename instead.                
--------------------------------------------------------------------------------

FILE:
modules/contrib/varbase_media/src/Plugin/Field/FieldFormatter/VarbaseOEmbedForma
tter.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 26   Class                                                       
                    Drupal\varbase_media\Plugin\Field\FieldFormatter\VarbaseOEmb
                    edFormatter extends @internal class                         
                    Drupal\media\Plugin\Field\FieldFormatter\OEmbedFormatter.   
--------------------------------------------------------------------------------

FILE: modules/contrib/varbase_media/varbase_media.install

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Ignore         41   Fetching deprecated class constant EXISTS_ERROR of class    
                    Drupal\Core\File\FileSystemInterface. Deprecated in         
                    drupal:10.3.0 and is removed from drupal:12.0.0. Use        
                    Drupal\Core\File\FileExists::Error instead.                 
--------------------------------------------------------------------------------

FILE: modules/contrib/varbase_media/varbase_media.info.yml

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 5    Value of core_version_requirement: ~10 is not compatible    
                    with the next major version of Drupal core. See             
                    https://drupal.org/node/3070687.                            
--------------------------------------------------------------------------------

FILE:
modules/contrib/varbase_media/modules/entity_browser_generic_embed/entity_browse
r_generic_embed.info.yml

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 5    Value of core_version_requirement: ~10 is not compatible    
                    with the next major version of Drupal core. See             
                    https://drupal.org/node/3070687.                            
--------------------------------------------------------------------------------

FILE:
modules/contrib/varbase_media/modules/varbase_media_instagram/varbase_media_inst
agram.info.yml

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 5    Value of core_version_requirement: ~10 is not compatible    
                    with the next major version of Drupal core. See             
                    https://drupal.org/node/3070687.                            
--------------------------------------------------------------------------------

FILE:
modules/contrib/varbase_media/modules/varbase_media_twitter/varbase_media_twitte
r.info.yml

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 5    Value of core_version_requirement: ~10 is not compatible    
                    with the next major version of Drupal core. See             
                    https://drupal.org/node/3070687.                            
--------------------------------------------------------------------------------

FILE: modules/contrib/varbase_media/composer.json

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 1    The drupal/core requirement is not compatible with the next 
                    major version of Drupal. Either remove it or update it to be
                    compatible. See                                             
                    https://www.drupal.org/docs/develop/using-composer/add-a-com
                    poserjson-file#core-compatibility.                          
--------------------------------------------------------------------------------

Comment #3

26 June 2024 at 13:23

Rajab Natshah committed 3de9f823 on 10.0.x

Issue #3457305: Update Drupal Core to ~10.3.0 and ~11.0.0 with support...

Comment #4

26 June 2024 at 13:40

Rajab Natshah committed c4e02adf on 9.1.x

Issue #3457305: Update Drupal Core to ~10.3.0 and ~11.0.0 with support...

Comment #5

rajab natshah

he/him

commented 26 June 2024 at 14:28

Issue summary:

View changes

Comment #6

26 June 2024 at 14:30

Rajab Natshah committed cb066c60 on 9.1.x

Issue #3457305: Switch to a Default Varbase Media recipe and drop the...

Comment #7

26 June 2024 at 14:42

Rajab Natshah committed 31abc47a on 10.0.x

Issue #3457305: Switch to a Default Varbase Media recipe and drop the...

Comment #8

rajab natshah

he/him

commented 26 June 2024 at 15:45

Assigned:	rajab natshah	» Unassigned
Issue summary:	View changes
Status:	Active	» Needs review
Issue tags:		+varbase-10.0.0, +varbase_media-9.1.11, +varbase-9.1.4, +varbase_media-10.0.2