Problem/Motivation

When trying to validate the tests in D9, 10, and 11, I could verify that the test failures are legitimate.

Panels is basically EOL, so I'm not going to spend time fixing this, but I'm closing the other test failure issues because there is a real problem, not just something built into the tests.

Steps to reproduce

On a stock drupal site, enable IPE and use page manager or anything else with panels and IPE, and it will fail to place blocks on the page.

Proposed resolution

Unknown, curious if anyone is actually using IPE successfully with panels right now.

Remaining tasks

Get a patch

Issue fork panels-3456918

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

japerry created an issue. See original summary.

joseph.olstad’s picture

joseph.olstad’s picture

inascon’s picture

StatusFileSize
new1016 bytes

I had the same problem and got the following error:

PHP Fatal error:  Declaration of Drupal\panels_ipe\Form\PanelsIPEBlockContentForm::actions(array $form, Drupal\Core\Form\FormStateInterface $form_state) must be compatible with Drupal\block_content\BlockContentForm::actions(array $form, Drupal\Core\Form\FormStateInterface $form_state): array in /Library/WebServer/Documents/dedicon-vookam/web/modules/contrib/panels/panels_ipe/src/Form/PanelsIPEBlockContentForm.php on line 18

So fixing the function declaration solved the problem for me.

joseph.olstad’s picture

Status: Active » Needs review

joelpittet made their first commit to this issue’s fork.

joelpittet’s picture

Status: Needs review » Fixed
StatusFileSize
new166.59 KB
new74.15 KB
new22.25 KB

Did a manual test to ensure this was fixed (screenshots to show it's not broken anymore)

Place a block:
Add block
Set it in a 2 column layout:
2 column layout
Login as another user to see it locked:
Locked as second user

These two fixes made this way smaller of a change:

AI helped me plow through the aged isssues to get this done, so also help to LLMs.

What this issue/MR fixed on top of those, to make it fully work + keep the tests green:

  • CategoryView AJAX accounting the form loader reset ajax.ajaxing = false early, which defeated core's ajaxComplete suppression and left drupalActiveXhrCount unbalanced (test teardown reported "Unfinished AJAX requests").
  • Uncached IPE build (#cache max-age 0) the editor render depends on the shared tempstore lock, which any user can change; without this, a second user was served a stale cached render and saw the editor as editable when it was actually locked.
  • Functional test helpers getWebDriverSession()->accept_alert()alert()->accept() for W3C WebDriver, and addBlock() now waits for the async-placed [data-block-id] before asserting.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.