Problem/Motivation

Attempting to upgrade to Drupal 10.3 the module blocks upgrading as it won't support the new version.

Steps to reproduce

composer upgrade -w

Proposed resolution

update composer constraints.

CommentFileSizeAuthor
mysql56-d10_3-upgrade.patch408 bytesemptyvoid

Issue fork mysql56-3456889

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

emptyvoid created an issue. See original summary.

guardiola86’s picture

guardiola86 commented

Patch works, thanks @emptyvoid. I encountered this issue though, composer was still complaining, because it was checking the version before applying the patch:

Problem 1
- Root composer.json requires drupal/mysql56 == 1.7.0.0 -> satisfiable by drupal/mysql56[1.7.0].
- drupal/mysql56 1.7.0 requires drupal/core ^9.4 || 10.0.* || 10.1.* || 10.2.* -> found drupal/core[9.4.0-alpha1, ..., 9.5.x-dev, 10.0.0-alpha1, ..., 10.2.x-dev] but these were not loaded, likely because it conflicts with another require.

So what I did was using https://github.com/mglaman/composer-drupal-lenient and adding the module to the section in composer.json:
"drupal-lenient": {
"allowed-list": [
"drupal/mysql56"
]
}

pierrepaul’s picture

pierrepaul commented
Status: Active » Reviewed & tested by the community

Works for me as well

pierrepaul’s picture

pierrepaul commented

I just noticed the README.md mention this :

This driver will be supported until Drupal 10.2's EOL of Dec 2024. It will most likely not work with Drupal 10.3 or higher.

So I'm not sure if this module is still required and if we should add support to Drupal 10.3. If someone has some insights on this... we could update the readme instead of the composer.json.

balsama’s picture

balsama
he/him
Primary language English
Location boston
commented

This driver will be supported until Drupal 10.2's EOL of Dec 2024. It will most likely not work with Drupal 10.3 or higher.

I _think_ that comment anticipated that #3343634: Add "json" as core data type to Schema and Database API would land prior to 10.3, which it didn't.

I'm not sure if this module is still required

So, if your platform still uses MySQL 5.6, you will need this module to run 10.3.

balsama opened merge request !3

effulgentsia made their first commit to this issue’s fork.

  • effulgentsia committed f1c1275e on 8.x-1.x authored by balsama 
    Issue #3456889 by balsama, emptyvoid, pierre paul lefebvre, guardiola86...
effulgentsia’s picture

effulgentsia commented
Version: 8.x-1.7 » 8.x-1.x-dev
Status: Reviewed & tested by the community » Fixed

#5 is correct. Since JSON queries haven't landed in Drupal 10, and Drupal 11 is already released, so they won't land in 10.4, 10.5, etc. either, we can both support 10.3 now, and relax the constraint to ^10 as #6's MR does. Therefore, merged this to 8.x-1.x.

I'll run some tests next week before tagging a release with this fix, but I don't expect that to uncover any major problems.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

bkosborne’s picture

bkosborne
Primary language English
Location New Jersey, USA
commented

Hi - can a new release please be tagged for this?