Problem/Motivation

After updating a site to Drupal 10.3, the active tab on our production environment has turned white-on-white. On dev, where the text colour is black, the active tab text *is* readable as black on white. The other tabs remain the configured colour for their environment.

This seems to be courtesy of .toolbar .toolbar-bar .toolbar-tab > .toolbar-item.is-active { in toolbar.theme.css in core.

Steps to reproduce

Configure colours for the environment on Drupal 10.2. See the active tab background be the configured colour. Update to Drupal 10.3.0. See the active tab background is now white.

Proposed resolution

Add an override to the css so that the active tab goes back to the colour that was configured in env indicator.

Remaining tasks

Pretty much all the work.

User interface changes

Ideally none.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#6 Screenshot_2024-06-24_10-05.png29.47 KBdagmar
#6 3456599-6.patch806 bytesdagmar
#5 Screenshot_2024-06-24_10-10.png27.26 KBdagmar
#3 3456599.patch835 bytesamit.mall

Comments

cafuego created an issue. See original summary.

cafuego’s picture

cafuego commented
Issue summary: View changes
amit.mall’s picture

amit.mall commented
StatusFileSize
new 3456599.patch835 bytes

@cafuego, overding color will not solve the issue in all cases, since we have made that section configrable from backend. So it's better not to change color of active tab. I have add exclude the active tab for color change, this will solve the issue. Find the patch for same

amit.mall’s picture

amit.mall commented
Status: Active » Needs review
dagmar’s picture

dagmar
Primary language Spanish
Location Argentina
commented
Status: Needs review » Needs work
StatusFileSize
new Screenshot_2024-06-24_10-10.png27.26 KB

Patch #3 does not work for me:

Failing patch

dagmar’s picture

dagmar
Primary language Spanish
Location Argentina
commented
Status: Needs work » Needs review
StatusFileSize
new 3456599-6.patch806 bytes
new Screenshot_2024-06-24_10-05.png29.47 KB 
$config['environment_indicator.indicator']['bg_color'] = '#00a073';
$config['environment_indicator.indicator']['fg_color'] = '#ffffff';

With this configuration and this patch I see this.

working patch

rauch’s picture

rauch commented

With the patch #3, the font color of the active tab is ok at page load. But switching tabs by clicking e.g. from "Manage" to "Admin" then the foreground color is used again (on my site white) and the font is not visible.

rauch’s picture

rauch commented

Patch #6 is working on my site. Thanks.

  • isholgueras committed 088b13fa on 4.x 
    Issue #3456599 by dagmar, amit.mall, cafuego, rauch: Toolbar active tab...
isholgueras’s picture

isholgueras commented
Status: Needs review » Fixed

I've reproduced the issue on 10.2, the patch #6 applies and fixes the issue.

Committed to 4.x and I will include it in the next release.

Thanks!

cafuego’s picture

cafuego commented

Gracias! :-)

drewcking’s picture

drewcking commented

Patch #6 is working for me on 10.3.0 as well.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.