🛑 Blocked on #3452397: Allow specifying default props values when opting an SDC in for XB.
SDC's optionally have examples.
⇒ They're not guaranteed to be present.
⇒ A preview is not guaranteed to work. 😱
This was fortunately fixed months ago. But it's achieved through hacky work-arounds rather than using the single source of Truth: XB's Component config entities.
\Drupal\experience_builder\Plugin\ComponentPluginManager::componentMeetsRequirements() (with a fix in #3470550: Component config entities are incomplete: missing entries for optional props, causing errors in ComponentPropsForm for an oversight).\Drupal\experience_builder\Controller\SdcController() to use that new default.\Drupal\experience_builder\Controller\SdcController::populatePropValues() and ::getDefaultValueFromPropInfo()None.
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | render-component-default-values.gif | 1.74 MB | wim leers |
| image-component-preview-fail.gif | 4.34 MB | wim leers |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
wim leersComment #3
wim leersComment #4
wim leersComment #5
wim leersThis blocks @bnjmnm over at #3452512: Add component instance edit form to contextual panel.
Comment #6
wim leers#3452397: Allow specifying default props values when opting an SDC in for XB is in.
Comment #7
wim leers⚠️ Note that this won't fix the problem demonstrated in the issue summary's GIF for the component, because for that #3460232: [PP-1] Support XB config entities with component trees that reference File/Media, use target_uuid and embed — aka: self-contained content entity dependencies must first happen on the config management side.
Comment #9
wim leersComment #10
wim leersWith this in place:
Comment #12
wim leersOops, sorry for overwriting your merging of upstream commits, @bnjmnm, that was unintentional 😅
Comment #14
wim leersWorking to get this issue's status/relevance updated, but blocked on @lauriii's confirmation at #3463999-7: Auto-create/update Component config entities for all discovered SDCs that meet XB's minimum criteria.
Comment #15
wim leersThis is no longer a blocker though.
#3463999: Auto-create/update Component config entities for all discovered SDCs that meet XB's minimum criteria is now in. Thanks to that issue, the following
if-test is obsolete — that is now a requirement for an SDC to become available in XB:Comment #16
wim leersI'll push this forward tomorrow. It's been lingering too long, and I'd like @f.mazeikis to remain focused on #3475584: Add support for Blocks as Components.
Comment #18
wim leersComment #19
wim leersNow properly ready for review! 😊
Comment #20
wim leersMy title update was lost 😬
P.S.: @f.mazeikis: Cypress E2E tests pass locally, they are currently super slow on GitLab CI. That's likely due to ephemeral load issues. Please re-run the pipeline when you review this, I bet it'll be green.
Comment #21
f.mazeikis commentedRe-ran pipeline and it's now passing. Code looks good too - certainly an improvement, even if we still need to come back to this once we have solutions for datetime and image (and entity references in general) props handling.
Comment #22
wim leersComment #24
wim leers