Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#7 Screenshot 2024-08-31 at 7.09.33 PM.png135.3 KBankitv18
#7 Screenshot 2024-08-31 at 7.09.25 PM.png184.71 KBankitv18
#7 Screenshot 2024-08-31 at 7.02.21 PM.png114.63 KBankitv18

Issue fork media_entity_instagram-3455619

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

chr.fritsch@gmx.net created an issue. See original summary.

chr.fritsch@gmx.net opened merge request !10

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
commented
Status: Active » Needs review

ankitv18 made their first commit to this issue’s fork.

ankitv18’s picture

ankitv18 commented

Done some minor cleanup in gitlab to run the test on D10.3 and above as d10.3 is default branch now.
All the pipelines are still passing. Will validate the changes on my local once before moving into RTBC.

rajeshreeputra made their first commit to this issue’s fork.

ankitv18’s picture

ankitv18 commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Screenshot 2024-08-31 at 7.02.21 PM.png114.63 KB
new Screenshot 2024-08-31 at 7.09.25 PM.png184.71 KB
new Screenshot 2024-08-31 at 7.09.33 PM.png135.3 KB

Changes looks good ~~ validated the changes on local as I have noticed ombedAPI forces for APP id and App Secret via META.
So moving both App id and Secret with constraint into schema is good way to handle this.
Marking this one RTBC.

chr.fritsch credited alexpott.

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
commented

  • chr.fritsch committed a9feaa72 on 4.x 
    Issue #3455619 by chr.fritsch, ankitv18, rajeshreeputra, alexpott:...
chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.