Problem/Motivation

Group Privacy module decorates service group_permission.checker. But it does it in a way, that no other decorators are allowed to run on the same service.

Steps to reproduce

Install this module, try to decorate service group_permission.checker with another custom module in the project. Observe that custom decorator is not called.

Proposed resolution

User inner service calls in the decorator instead of parent. See https://symfony.com/doc/current/service_container/service_decoration.html

Remaining tasks

Create MR and/or patch

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#3 3455028-decoration-3.patch4.29 KBa.dmitriiev

Issue fork group_privacy-3455028

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

a.dmitriiev created an issue. See original summary.

a.dmitriiev opened merge request !2

a.dmitriiev’s picture

a.dmitriiev commented
Status: Active » Needs review
StatusFileSize
new 3455028-decoration-3.patch4.29 KB

Uploading patch for projects with composer patches plugin

dylan donkersgoed made their first commit to this issue’s fork.

dylan donkersgoed’s picture

dylan donkersgoed commented

Thanks @a.dmitriiev. I've also pushed up a change to switch the class to implement the interface rather than extending the base class as I understand this to also be preferred when decorating services.

I don't expect this to interfere with your decoration, but you may wish to double check when next you upgrade the module, or if you were referencing the MR directly in your composer patches.

dylan donkersgoed’s picture

dylan donkersgoed commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.