Problem/Motivation

Unfortunately, search_api publish a minor update, where the changed the declaration of \Drupal\search_api\Backend\BackendPluginBase::__sleep. This causes a WSOD on PHP 8.1 and later.

Proposed resolution

Update \Drupal\elasticsearch_connector\Plugin\search_api\backend\SearchApiElasticsearchBackend::__sleep to use the same method declaration.

Remaining tasks

  1. Write a patch
  2. Review and feedback
  3. RTBC and feedback
  4. Commit
  5. Release — released in 8.0.0-alpha1

User interface changes

None.

API changes

  1. Specifies return type for \Drupal\elasticsearch_connector\Plugin\search_api\backend\ElasticSearchBackend::__sleep()
  2. Adds \Drupal\elasticsearch_connector\Plugin\search_api\backend\ElasticSearchBackend::__wakeup()

Data model changes

None.

Issue fork elasticsearch_connector-3454977

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jurgenhaas created an issue. See original summary.

jurgenhaas opened merge request !54

jurgenhaas’s picture

jurgenhaas
he/him
Primary language German
Location Gottmadingen
commented
Status: Active » Needs review
sokru’s picture

sokru commented
Status: Needs review » Needs work

Tests are failing. Wonder if the change should added also to src/SearchAPI/BackendClient.php?

  • sokru committed 59f70b12 on 8.0.x authored by jurgenhaas 
    Issue #3454977 by jurgenhaas, sokru: WSOD if search_api 1.35 ist...
sokru’s picture

sokru commented
Title: WSOD if search_api 1.35 ist installed » WSOD if search_api 1.35 is installed
Status: Needs work » Fixed

Tests passed and since this is critical issue, I committed this. Thanks @jurgenhaas for reporting!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

mparker17’s picture

mparker17
he/him
Primary language English
Location UTC-5
commented
Issue summary: View changes

Update issue summary to note release version, explain API changes.