Problem/Motivation

Drupal 11 came out on August 2nd, 2024.

Proposed resolution

Update the sitemap module to be compatible with Drupal 11.

Remaining tasks

  1. Write a patch
  2. Review and feedback
  3. RTBC and feedback
  4. Commit

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#12 config_page.png78.44 KBtirupati_singh
#12 sitemap-d11.png98.67 KBtirupati_singh
#9 sitemap.png76.35 KBchaitanyadessai
#7 Screenshot from 2024-06-28 00-23-15.png180.4 KBarijit acharya
#3 Drupal_11_compatibility-3454907.patch1.83 KBsarwan_verma

Issue fork sitemap-3454907

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

naveenvalecha created an issue. See original summary.

naveenvalecha’s picture

naveenvalecha
He/Him
commented
Title: Drupal 11 Compatibility » Drupal 11 compatibility fixes for sitemap
Issue summary: View changes
sarwan_verma’s picture

sarwan_verma commented
Status: Active » Needs review
StatusFileSize
new Drupal_11_compatibility-3454907.patch1.83 KB

Hi @naveenvalecha,

I have fixed this "Drupal 11 compatibility fixes for sitemap" and also attached patch ,
please review and verify .

naveenvalecha’s picture

naveenvalecha
He/Him
commented
Status: Needs review » Needs work

@sarwan_verma
Thank you for your contribution. Please create a Merge request https://www.drupal.org/docs/develop/git/using-gitlab-to-contribute-to-dr...

sarwan_verma opened merge request !25

sarwan_verma’s picture

sarwan_verma commented
Status: Needs work » Needs review

Hi@naveenvalecha,

I have created MR. please review it once.

arijit acharya’s picture

arijit acharya commented
Status: Needs review » Needs work
StatusFileSize
new Screenshot from 2024-06-28 00-23-15.png180.4 KB

Applied the patch in #3 and the MR in #5, both are applied successfully. But on visiting the config page/admin/config/search/sitemap getting the below error.
error img
Moving this to NW.

arijit acharya’s picture

arijit acharya commented
Assigned: Unassigned » arijit acharya
chaitanyadessai’s picture

chaitanyadessai commented
Status: Needs work » Needs review
StatusFileSize
new sitemap.png76.35 KB

MR and patch applied successfully no errors found attaching ss.

arijit acharya’s picture

arijit acharya commented

@chaitanyadessai Can you confirm on which drupal version you are testing? It seems, you are testing it against D10 or below. However the issue is for D11.
Also I have added a commit in the MR, which resolved the issue.

arijit acharya’s picture

arijit acharya commented
Assigned: arijit acharya » Unassigned
tirupati_singh’s picture

tirupati_singh commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new sitemap-d11.png98.67 KB
new config_page.png78.44 KB

I've applied the MR as a patch and the patch applied with no errors. After applying the patch the module is now compatible with Drupal 11 and it's working fine. Getting no error on visiting the module config page /admin/config/search/sitemap. Attaching the screenshots of the module config and sitemap page for reference.

mparker17 made their first commit to this issue’s fork.

mparker17’s picture

mparker17
he/him
Primary language English
Location UTC-5
commented
Issue summary: View changes

Updated the issue summary.

mparker17’s picture

mparker17
he/him
Primary language English
Location UTC-5
commented
Issue summary: View changes

The code in the merge request had several PHPCS and PHPStan errors; and none of the changes accounted for the Book module moving into contrib in Drupal 11, so I had to make extensive changes to the merge request to account for that (via a new sitemap_book sub-module).

I couldn't figure out how to move the book-plugin-specific config into the new sitemap_book sub-module, so I've created #3465577: Split sitemap_book config schema from sitemap schema to follow up on this.

mparker17’s picture

mparker17
he/him
Primary language English
Location UTC-5
commented
Issue summary: View changes
Status: Reviewed & tested by the community » Fixed

Going to mark this as fixed; I'll create a new release after resolving some other issues.

mparker17’s picture

mparker17
he/him
Primary language English
Location UTC-5
commented

Note that this change was released in sitemap-8.x-2.0-beta7, but resulted in a follow-up issue, #3466530: Error when running sitemap_update_8202, which was released in sitemap-8.x-2.0-beta8.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.