Problem/Motivation

The Views Reference Settings do not have test coverage.

Steps to reproduce

Check the tests folder.

Proposed resolution

Add test coverage.

Remaining tasks

Add test coverage.

User interface changes

None

API changes

None

Data model changes

None

Issue fork viewsreference-3453902

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

scott_euser created an issue. See original summary.

scott_euser’s picture

scott_euser commented
Assigned: scott_euser » Unassigned
Status: Active » Needs work

This adds test coverage for Pager only so far. Going to park here until the chain of merging is completed. Ie merging:

  1. #3317635: Coding standards
  2. #3161731: Add basic test coverage for the widgets and plugins
  3. #3453893: Add functional coverage (without needing JS), support using the module without JS

scott_euser opened merge request !55

scott_euser changed the visibility of the branch 3453902-settings-test-coverage to hidden.

scott_euser’s picture

scott_euser commented
Status: Needs work » Needs review

Okay test coverage for all built in Views Reference Settings now. Requires merging #3453893: Add functional coverage (without needing JS), support using the module without JS first though as these tests rely on Views Reference being usable without JS.

  • scott_euser committed 9f8c2141 on 8.x-2.x 
    Issue #3453902: Add test coverage for the views settings plugins
scott_euser’s picture

scott_euser commented
Status: Needs review » Fixed

Test only MR, so merging on my own as discussed. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.