Problem/Motivation

Drupal CI is being phased out. As this module already uses GitLab CI for the 8.x-3.x branch, the only thing preventing the removal of Drupal CI in https://www.drupal.org/node/583948/qa is the fact that the 7.x-2.x branch still uses it.

Proposed resolution

  1. Add GitLab CI to the 7.x-2.x branch
  2. Delete the Drupal CI in https://www.drupal.org/node/583948/qa

Issue fork feeds-3452940

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jcnventura created an issue. See original summary.

jcnventura opened merge request !175

jcnventura’s picture

jcnventura
Primary language English
commented
Status: Active » Reviewed & tested by the community

Not much to review here...

megachriz’s picture

megachriz
Primary language Dutch
commented
Status: Reviewed & tested by the community » Needs work

Hm, but it does fail tests. Is that perhaps caused by issues in modules that the D7 version of Feeds depends or integrates with? For example: Job Scheduler, Date, Organic Groups, Feeds XPath Parser...

jcnventura’s picture

jcnventura
Primary language English
commented

Yes, most likely this needs at least a composer.json with the correct require-dev, similarly to the D8+ composer.json.

megachriz’s picture

megachriz
Primary language Dutch
commented

I also see the tests are using PHP 8.1. Would it work better if we use PHP 7.4 on GitLab CI instead? At least for now, so we have better hopes of passing tests. Tests fail on PHP 8 on Drupal CI as well, where the PHP 8.1 failures look related to Job Scheduler.

megachriz’s picture

megachriz
Primary language Dutch
commented

We could also perhaps disable (or rewrite?) some of the tests. For example, Feeds XPath Parser is an abandoned project, so that one is unlikely to get PHP 8 compatibility. It was replaced by Feeds Extensible Parsers almost a decade ago.

jcnventura’s picture

jcnventura
Primary language English
commented

I believe we can force the PHP version in the tests for this to be 7.4. Need to investigate further.

joelpittet made their first commit to this issue’s fork.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs work » Needs review

Changed the template comments to the current template and read the docs on the test dependencies:
https://project.pages.drupalcode.org/gitlab_templates/info/drupal7/#depe...

This is the first one of these I am doing, so we'll see how it goes...

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented

Getting a bit closer...

I have it set to PHP 7.4 which did help.

MAX PHP: https://git.drupalcode.org/project/feeds/-/jobs/1864063
Not MAX PHP: https://git.drupalcode.org/project/feeds/-/jobs/1864177
PHP 7.4 explicit: https://git.drupalcode.org/project/feeds/-/jobs/1864327

I will likely disable some tests if they are from third party integrations failing:

  1. Organic groups integration 0 passes, 4 fails, and 3 exceptions
  2. Rules integration 0 passes, 4 fails, and 7 exceptions

I might also create a new release for OG to help here too...

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs review » Fixed

  • joelpittet committed b2f4d6d3 on 7.x-2.x authored by jcnventura 
    Issue #3452940 by joelpittet, jcnventura, MegaChriz: Add GitLab CI to D7...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.