Closed (fixed)
Project:
Simple OAuth (OAuth2) & OpenID Connect
Version:
6.0.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
4 Jun 2024 at 13:07 UTC
Updated:
10 Jul 2024 at 07:39 UTC
Jump to comment: Most recent
Comments
Comment #2
vipin.mittal18Comment #5
rajeshreeputraI believe that with the release of version 6.x, we should consider discontinuing support for early versions of Drupal and those that are end-of-life (EOL). I would appreciate the opinions of the maintainers on this matter. If necessary, we could maintain compatibility with earlier versions within the 5.x branch.
Comment #6
rajeshreeputraWe have observed that tests are failing in the upcoming minor and major releases because there is a new requirement dictating that, starting with version 10.3, the provider functions must be declared as static. It has come to our attention that the getRandomGenerator method within the RandomGeneratorTrait is not currently static.
We would greatly appreciate any guidance or insights from the maintainer and the community on how to best address this change. Your assistance in this matter would be invaluable.
Comment #8
ankitv18 commentedFor Drush 12 and above support Module needs to made changes in the commands see: https://www.drush.org/12.x/commands/
For this we need to log a separate issue.
And I guess in this module we need to drop the D9 support as it will throw a php fatal error: https://git.drupalcode.org/issue/simple_oauth-3452470/-/jobs/1844209#L294 because you made changes in the type hint of methods.
For example: Drupal\simple_oauth\Normalizer\TokenEntityNormalizer::normalize()
With 6.0.x version is still in Beta stage I would suggest to support only D10 and 11 as 5.0.x version is also providing D9 and D10. (If maintainer agrees on this one then only change need to do info.yml https://git.drupalcode.org/project/simple_oauth/-/merge_requests/130/dif...)
Comment #9
ankitv18 commentedWe can create a separate issue for next major phpunit: https://git.drupalcode.org/issue/simple_oauth-3452470/-/jobs/1851832#L89
To fix dataProvider issue I have used https://git.drupalcode.org/issue/simple_oauth-3452470/-/jobs/1851832#L89 to avoid the $this object and create the RandomString to make the assertions.
Comment #10
vishalkhode commentedComment #11
rajeshreeputraComment #13
bojan_dev commentedNice work, TY!