Problem/Motivation

This module is using GitLab CI and most of the tests pass, but the phpcs tests are failing in a way that can be fixed automatically.

Let's fix this and, to prevent regressions, require composer-lint, cspell, and phpcs (which will all pass with this MR) to pass in the future. (By default, the GitLab CI template only requires phpunit tests to pass.)

Issue fork token_filter-3450362

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

ptmkenny created an issue. See original summary.

ptmkenny’s picture

ptmkenny commented
Title: Fix phpcs issues and require composer-lint, cspell, and phpcs to pass » Require composer-lint, cspell, phpcs, and stylelint to pass

ptmkenny opened merge request !17

ptmkenny’s picture

ptmkenny commented
Status: Active » Needs review

This MR does three things:

darvanen’s picture

darvanen
he/him
Primary language English
Location Sydney, Australia
commented
Status: Needs review » Reviewed & tested by the community

Brilliant, thanks @ptmkenny!

Looks good to me.

  • darvanen committed 91c8fc93 on 2.x authored by ptmkenny 
    Issue #3450362 by ptmkenny, darvanen: Require composer-lint, cspell,...
darvanen’s picture

darvanen
he/him
Primary language English
Location Sydney, Australia
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.