Problem/Motivation

Drupal 11 is now in beta. Let's upgrade this module to Drupal 11; I just checked it with Upgrade Status and it looks quite simple.

Issue fork real_aes-3448016

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

ptmkenny created an issue. See original summary.

ptmkenny opened merge request !8

ptmkenny’s picture

ptmkenny commented
Status: Active » Needs review
ptmkenny’s picture

ptmkenny commented

This MR adds support for Drupal 11 and removes support for Drupal 8 + 9.

jcnventura’s picture

jcnventura
Primary language English
commented
Status: Needs review » Needs work

Why needlessly remove support for Drupal 8 and 9? If there's any change that warrants dropping those versions, then by all means, drop them. But consider that there are about as many sites running D8 and D9 as those that run D10. Why drop support for half of the possible sites?

ptmkenny’s picture

ptmkenny commented
Status: Needs work » Needs review

Drupal 8 core has been out of support for over 2 years now, and Drupal 9 has been out of support since last year. Keeping support for 8 + 9 means that PHP 8 features can't be used. So I would move to drop support for unsupported core versions.

However, this is a decision for the maintainers, not me, so I've added another branch that keeps 8 + 9 support.

jcnventura’s picture

jcnventura
Primary language English
commented

When the point comes that this module wants to support PHP 8, it can certainly do so, and if that breaks the support for Drupal 8 and 9, so be it. I don't think that a separate branch to support unsupported versions is needed. What I'm saying is that the change here to add support to Drupal 11 is not doing any change that would break the support for Drupal 8 and 9, so removing that seems unnecessary.

Note that Drupal 9 also supported PHP 8, and it is very likely that there are Drupal 8 sites out there also running on PHP 8. The module can certainly require PHP 8 or above on it's own by specifying that requirement in the composer.json.

ptmkenny closed merge request !8

ptmkenny opened merge request !12

ptmkenny’s picture

ptmkenny commented

@jcventura Ok, you have persuaded me. I closed the MR dropping 8/9 support and opened a new one that only adds support for D11.

rlhawk’s picture

rlhawk
Primary language English
Location Seattle, Washington, United States
commented
Status: Needs review » Reviewed & tested by the community

I agree with keeping support for Drupal 8 and 9 until we're forced to drop it.

ptmkenny’s picture

ptmkenny commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.